Re: [PATCH v2 00/13] Xilinx Video IP Core support

[Hans Verkuil <hverkuil@xs4all.nl>]

Hi Laurent,

On 11/02/2014 03:53 PM, Laurent Pinchart wrote:
> Hello,
> 
> Here's the second version of the Xilinx FPGA Video IP Cores kernel drivers.
> 
> I won't detail in great lengths the Xilinx Video IP architecture here, as that
> would result in dozens of pages of documentation. The interested reader can
> refer to the Zynq ZC702 Base TRD (Targeted Reference Design) User Guide
> (http://www.xilinx.com/support/documentation/boards_and_kits/zc702_zvik/2014_2/ug925-zynq-zc702-base-trd.pdf).
> 
> In a nutshell, the Xilinx Video IP Cores architecture specifies how
> video-related IP cores need to be designed to interoperate and how to assemble
> them in pipelines of various complexities. The concepts map neatly to the
> media controller architecture, which this patch set uses extensively.
> 
> The series starts with various new V4L2 core features, bug fixes or cleanups,
> with a small documentation enhancement (01/13), the addition of new media bus
> formats needed by the new drivers (02/13 to 04/13) and a new V4L2 OF link
> parsing function (05/13).
> 
> The next two patches (06/13 and 07/13) fix two race conditions in videobuf2.
> They could be applied seperately from this series as they're not specific to
> Xilinx drivers.
> 
> The next three patches (08/13 to 10/13) fix bugs in the Xilinx Video DMA
> driver. They are required as a runtime dependency but will not break
> compilation. I will submit a separate pull request for them through the DMA
> engine tree.
> 
> The last three patches are the core of this series.
> 
> Patch 11/13 adds support for the Xilinx Video IP architecture core in the form
> of a base object to model video IP cores (xilinx-vip.c - Video IP), a
> framework that parses a DT representation of a video pipeline and connects the
> corresponding V4L2 subdevices together (xilinx-vipp.c - Video IP Pipeline) and
> a glue between the Video DMA engine driver and the V4L2 API (xilinx-dma.c).
> 
> Patch 12/13 adds a driver for the Video Timing Controller (VTC) IP core. While
> not strictly a video processing IP core, the VTC is required by other video IP
> core drivers.
> 
> Finally, patch 13/13 adds a first video IP core driver for the Test Pattern
> Generator (TPG). Drivers for other IP cores will be added in the future.

Can you add a 'Changes since' section next time? It helps reviewing.

For patches 1-7 and 12-13:

Acked-by: Hans Verkuil <hans.verkuil@cisco.com>

Regards,

	Hans

> 
> Cc: devicetree@vger.kernel.org
> 
> Hyun Kwon (2):
>   v4l: Sort YUV formats of v4l2_mbus_pixelcode
>   v4l: Add VUY8 24 bits bus format
> 
> Laurent Pinchart (8):
>   media: entity: Document the media_entity_ops structure
>   v4l: Add RBG and RGB 8:8:8 media bus formats on 24 and 32 bit busses
>   v4l: of: Add v4l2_of_parse_link() function
>   v4l: vb2: Fix race condition in vb2_fop_poll
>   v4l: vb2: Fix race condition in _vb2_fop_release
>   v4l: xilinx: Add Xilinx Video IP core
>   v4l: xilinx: Add Video Timing Controller driver
>   v4l: xilinx: Add Test Pattern Generator driver
> 
> Srikanth Thokala (3):
>   dma: xilinx: vdma: Check if the segment list is empty in a descriptor
>   dma: xilinx: vdma: Allow only one chunk in a line
>   dma: xilinx: vdma: icg should be difference of stride and hsize
> 
>  Documentation/DocBook/media/v4l/subdev-formats.xml | 719 +++++++++-------
>  .../devicetree/bindings/media/xilinx/video.txt     |  52 ++
>  .../devicetree/bindings/media/xilinx/xlnx,v-tc.txt |  33 +
>  .../bindings/media/xilinx/xlnx,v-tpg.txt           |  68 ++
>  .../bindings/media/xilinx/xlnx,video.txt           |  55 ++
>  MAINTAINERS                                        |  10 +
>  drivers/dma/xilinx/xilinx_vdma.c                   |  13 +-
>  drivers/media/platform/Kconfig                     |   1 +
>  drivers/media/platform/Makefile                    |   2 +
>  drivers/media/platform/xilinx/Kconfig              |  23 +
>  drivers/media/platform/xilinx/Makefile             |   5 +
>  drivers/media/platform/xilinx/xilinx-dma.c         | 770 +++++++++++++++++
>  drivers/media/platform/xilinx/xilinx-dma.h         | 109 +++
>  drivers/media/platform/xilinx/xilinx-tpg.c         | 921 +++++++++++++++++++++
>  drivers/media/platform/xilinx/xilinx-vip.c         | 269 ++++++
>  drivers/media/platform/xilinx/xilinx-vip.h         | 227 +++++
>  drivers/media/platform/xilinx/xilinx-vipp.c        | 669 +++++++++++++++
>  drivers/media/platform/xilinx/xilinx-vipp.h        |  49 ++
>  drivers/media/platform/xilinx/xilinx-vtc.c         | 386 +++++++++
>  drivers/media/platform/xilinx/xilinx-vtc.h         |  42 +
>  drivers/media/v4l2-core/v4l2-of.c                  |  61 ++
>  drivers/media/v4l2-core/videobuf2-core.c           |  35 +-
>  include/media/media-entity.h                       |   9 +
>  include/media/v4l2-of.h                            |  27 +
>  include/uapi/linux/Kbuild                          |   1 +
>  include/uapi/linux/v4l2-mediabus.h                 |  19 +-
>  include/uapi/linux/xilinx-v4l2-controls.h          |  73 ++
>  27 files changed, 4302 insertions(+), 346 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/media/xilinx/video.txt
>  create mode 100644 Documentation/devicetree/bindings/media/xilinx/xlnx,v-tc.txt
>  create mode 100644 Documentation/devicetree/bindings/media/xilinx/xlnx,v-tpg.txt
>  create mode 100644 Documentation/devicetree/bindings/media/xilinx/xlnx,video.txt
>  create mode 100644 drivers/media/platform/xilinx/Kconfig
>  create mode 100644 drivers/media/platform/xilinx/Makefile
>  create mode 100644 drivers/media/platform/xilinx/xilinx-dma.c
>  create mode 100644 drivers/media/platform/xilinx/xilinx-dma.h
>  create mode 100644 drivers/media/platform/xilinx/xilinx-tpg.c
>  create mode 100644 drivers/media/platform/xilinx/xilinx-vip.c
>  create mode 100644 drivers/media/platform/xilinx/xilinx-vip.h
>  create mode 100644 drivers/media/platform/xilinx/xilinx-vipp.c
>  create mode 100644 drivers/media/platform/xilinx/xilinx-vipp.h
>  create mode 100644 drivers/media/platform/xilinx/xilinx-vtc.c
>  create mode 100644 drivers/media/platform/xilinx/xilinx-vtc.h
>  create mode 100644 include/uapi/linux/xilinx-v4l2-controls.h
>