From: Adrian Hunter <adrian.hunter@intel.com>
To: Johan Rudholm <johan.rudholm@axis.com>
Cc: "Johan Rudholm" <johanru@axis.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"Chris Ball" <chris@printf.net>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Guennadi Liakhovetski" <g.liakhovetski@gmx.de>,
"David Lanzendörfer" <david.lanzendoerfer@o2s.ch>,
"Jesper Nilsson" <jespern@axis.com>
Subject: Re: [PATCH 3/4] mmc: core: make hw_reset generic
Date: Mon, 03 Nov 2014 12:56:04 +0200 [thread overview]
Message-ID: <54575F44.1000503@intel.com> (raw)
In-Reply-To: <CA+20K0A6qKkEb=pGgFUn=Z07_YmqW1ot=LjPswDx6MzBpwP9ZQ@mail.gmail.com>
On 03/11/14 12:19, Johan Rudholm wrote:
> 2014-11-03 10:20 GMT+01:00 Adrian Hunter <adrian.hunter@intel.com>:
>> On 24/10/14 15:46, Johan Rudholm wrote:
>>> Move the (e)MMC specific hw_reset code from core.c into mmc.c and call
>>> it from the new bus_ops member power_reset. This also lets us add code
>>
>> power_reset is not a good name because it does not necessarily have
>> anything to do with power. I am not sure why you don't stick with
>> hw_reset.
>>
>>> for reseting SD cards as well.
>>>
>>> Rename the mmc_hw_reset* functions into mmc_reset*, since what they
>>> now actually do depends on the device type (and it may be something else
>>> than doing a hw_reset).
>>
>> I don't follow your reasoning about the rename. Cycling the power is
>> a kind of hardware reset isn't it.
>
> Since we finalize the reset by calling bus_ops->power_restore, I was
> looking for something symmetrical. Ulf mentioned perhaps extending
> bus_ops->power_save, but I couldn't find a reasonable way of doing
> this. Do you propose simply calling it bus_ops->hw_reset ?
Yes
next prev parent reply other threads:[~2014-11-03 10:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 12:46 [PATCH 0/4] mmc: core: hw_reset changes Johan Rudholm
2014-10-24 12:46 ` [PATCH 1/4] mmc: core: use mmc_send_status to check hw_reset Johan Rudholm
2014-10-24 12:46 ` [PATCH 2/4] mmc: core: use mmc_power_up in hw_reset Johan Rudholm
2014-11-03 9:21 ` Adrian Hunter
2014-11-03 10:13 ` Johan Rudholm
2014-11-03 10:59 ` Adrian Hunter
2014-10-24 12:46 ` [PATCH 3/4] mmc: core: make hw_reset generic Johan Rudholm
2014-11-03 9:20 ` Adrian Hunter
2014-11-03 10:19 ` Johan Rudholm
2014-11-03 10:56 ` Adrian Hunter [this message]
2014-10-24 12:46 ` [PATCH 4/4] mmc: sd: add power_reset callback Johan Rudholm
2014-11-03 8:46 ` [PATCH 0/4] mmc: core: hw_reset changes Johan Rudholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54575F44.1000503@intel.com \
--to=adrian.hunter@intel.com \
--cc=chris@printf.net \
--cc=david.lanzendoerfer@o2s.ch \
--cc=g.liakhovetski@gmx.de \
--cc=jespern@axis.com \
--cc=johan.rudholm@axis.com \
--cc=johanru@axis.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.