All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: "Cédric Le Goater" <clg@fr.ibm.com>
Cc: aik@ozlabs.ru, paulus@samba.org, qemu-ppc@nongnu.org,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH] target-ppc: explicitly save page table headers in big endian
Date: Mon, 03 Nov 2014 15:53:02 +0100	[thread overview]
Message-ID: <545796CE.2010706@suse.de> (raw)
In-Reply-To: <1414405406-653-1-git-send-email-clg@fr.ibm.com>



On 27.10.14 11:23, Cédric Le Goater wrote:
> Currently, when the page tables are saved, the kvm_get_htab_header structs 
> and the ptes are assumed being big endian and dumped as a indistinct blob 
> in the statefile. This is no longer true when the host is little endian 
> and this breaks restoration.
> 
> This patch unfolds the kvmppc_save_htab routine to write explicitly the 
> kvm_get_htab_header structs in big endian. The ptes are left untouched.
> 
> Signed-off-by: Cédric Le Goater <clg@fr.ibm.com>
> Cc: paulus@samba.org
> Cc: aik@ozlabs.ru
> Cc: gkurz@linux.vnet.ibm.com

LGTM :)


Alex

  reply	other threads:[~2014-11-03 14:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-27 10:23 [Qemu-devel] [RFC PATCH] target-ppc: explicitly save page table headers in big endian Cédric Le Goater
2014-11-03 14:53 ` Alexander Graf [this message]
2014-11-03 14:56   ` Cedric Le Goater
2014-11-03 15:10     ` Alexander Graf
2014-11-13  6:43       ` Alexey Kardashevskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545796CE.2010706@suse.de \
    --to=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=clg@fr.ibm.com \
    --cc=paulus@samba.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.