From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 10/10] xen/arm: Handle different bootwrapper locations for Hip04 platform Date: Mon, 03 Nov 2014 15:40:14 +0000 Message-ID: <5457A1DE.3030104@linaro.org> References: <1415009522-6344-1-git-send-email-frediano.ziglio@huawei.com> <1415009522-6344-11-git-send-email-frediano.ziglio@huawei.com> <54578DA7.9080505@linaro.org> <5457A034.1030008@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Frediano Ziglio , Ian Campbell , Stefano Stabellini , Tim Deegan Cc: Zoltan Kiss , Zoltan Kiss , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 11/03/2014 03:36 PM, Frediano Ziglio wrote: >> On 11/03/2014 03:28 PM, Frediano Ziglio wrote: >>>> >>>> Hi Frediano, >>>> >>>> This could be merged in #1. >>>> >>>> Regards, >>>> >>> >>> No, as it require the patch just before it so merging to #1 cause a >> commit that does not compile >> >> Why don't you move the patch #9 earlier in the patch series too? >> >> Regards, >> > > So move patch #9 and #10 in another position? Looks ok, which position? I would move #9 to the top of the list and merge #10 in the current #1. > I did most of changes you requested. I was thinking to post another version with this last change. > > The change suggested by Ian (do not use a quirk) is still in my TODO list as could be quite big. > > I don't know which constant I should use for the 510 number. The first one is not useful as it will catch buggy hardware, the second could be replace by nr_lines. So you could even drop the 2 510. -- Julien Grall