From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v4 03/14] regulator: of: Add regulator desc param to of_get_regulator_init_data() Date: Mon, 03 Nov 2014 16:48:34 +0100 Message-ID: <5457A3D2.1090602@collabora.co.uk> References: <1415025649-8119-1-git-send-email-javier.martinez@collabora.co.uk> <1415025649-8119-4-git-send-email-javier.martinez@collabora.co.uk> <20141103153303.GQ3815@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from bhuna.collabora.co.uk ([93.93.135.160]:38992 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752260AbaKCPsl (ORCPT ); Mon, 3 Nov 2014 10:48:41 -0500 In-Reply-To: <20141103153303.GQ3815@sirena.org.uk> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Mark Brown Cc: Kukjin Kim , Chanwoo Choi , Olof Johansson , Chris Zhong , Krzysztof Kozlowski , Abhilash Kesavan , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org On 11/03/2014 04:33 PM, Mark Brown wrote: > On Mon, Nov 03, 2014 at 03:40:38PM +0100, Javier Martinez Canillas wrote: > >> for_each_child_of_node(nproot, np) { >> if (!of_node_cmp(np->name, info->desc.name)) { >> config->init_data = >> - of_get_regulator_init_data(&pdev->dev, np); >> + of_get_regulator_init_data(&pdev->dev, np, >> + NULL); > > This looks buggy, we're not passing in a descriptor. > The descriptor is only used when extracting the init_data to map the modes and since it was not a parameter before, some drivers needs to be refactored to pass that information. I thought that instead of adding intrusive changes in drivers that I don't have hw to test, that parameter could be optional so the patch that use that information check if the descriptor and the map_modes function pointer are not NULL. Best regards, Javier