From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlKH6-0007wK-5F for qemu-devel@nongnu.org; Mon, 03 Nov 2014 11:14:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlKH0-00065s-MM for qemu-devel@nongnu.org; Mon, 03 Nov 2014 11:14:36 -0500 Received: from mail-la0-x22a.google.com ([2a00:1450:4010:c03::22a]:56408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlKH0-00065b-C2 for qemu-devel@nongnu.org; Mon, 03 Nov 2014 11:14:30 -0500 Received: by mail-la0-f42.google.com with SMTP id gq15so9906763lab.1 for ; Mon, 03 Nov 2014 08:14:28 -0800 (PST) Sender: Paolo Bonzini Message-ID: <5457A9E0.3020303@redhat.com> Date: Mon, 03 Nov 2014 17:14:24 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1414731141-13086-1-git-send-email-syeon.hwang@samsung.com> In-Reply-To: <1414731141-13086-1-git-send-email-syeon.hwang@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: changed to proper enum type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: SeokYeon Hwang , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com On 31/10/2014 05:52, SeokYeon Hwang wrote: > To fix compiler warning on clang > 3.4, changed to proper enum type. > > Signed-off-by: SeokYeon Hwang > --- > block.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/block.c b/block.c > index 88f6d9b..50845a4 100644 > --- a/block.c > +++ b/block.c > @@ -3540,10 +3540,10 @@ static void send_qmp_error_event(BlockDriverState *bs, > BlockErrorAction action, > bool is_read, int error) > { > - BlockErrorAction ac; > + IoOperationType operation; > > - ac = is_read ? IO_OPERATION_TYPE_READ : IO_OPERATION_TYPE_WRITE; > - qapi_event_send_block_io_error(bdrv_get_device_name(bs), ac, action, > + operation = is_read ? IO_OPERATION_TYPE_READ : IO_OPERATION_TYPE_WRITE; > + qapi_event_send_block_io_error(bdrv_get_device_name(bs), operation, action, > bdrv_iostatus_is_enabled(bs), > error == ENOSPC, strerror(error), > &error_abort); > Hi, I think a similar patch has already been posted. Paolo