From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bn1on0133.outbound.protection.outlook.com ([157.56.110.133]:3234 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753642AbaKCT5y (ORCPT ); Mon, 3 Nov 2014 14:57:54 -0500 Message-ID: <5457DE30.3010200@amd.com> Date: Mon, 3 Nov 2014 13:57:36 -0600 From: Suravee Suthikulanit MIME-Version: 1.0 To: Marc Zyngier CC: Mark Rutland , "jason@lakedaemon.net" , "tglx@linutronix.de" , "Catalin Marinas" , Will Deacon , Liviu Dudau , "Harish.Kasiviswanathan@amd.com" , "linux-arm-kernel@lists.infradead.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [V9 PATCH 2/2] irqchip: gicv2m: Add supports for ARM GICv2m MSI(-X) References: <1414743990-28421-1-git-send-email-suravee.suthikulpanit@amd.com> <1414743990-28421-3-git-send-email-suravee.suthikulpanit@amd.com> <54574FF7.706@arm.com> In-Reply-To: <54574FF7.706@arm.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Sender: linux-pci-owner@vger.kernel.org List-ID: On 11/3/2014 3:50 AM, Marc Zyngier wrote: >> diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c >> >index a99c211..4069eb3 100644 >> >--- a/drivers/irqchip/irq-gic.c >> >+++ b/drivers/irqchip/irq-gic.c >> >@@ -46,6 +46,7 @@ >> > #include >> > >> > #include "irq-gic-common.h" >> >+#include "irq-gic-v2m.h" >> > #include "irqchip.h" >> > >> > union gic_base { >> >@@ -68,6 +69,9 @@ struct gic_chip_data { >> > #ifdef CONFIG_GIC_NON_BANKED >> > void __iomem *(*get_base)(union gic_base *); >> > #endif >> >+#ifdef CONFIG_ARM_GIC_V2M >> >+ struct list_head v2m_list; >> >+#endif > Can't that be something private to the v2m widget driver? I don't think > it brings anything to the main GIC driver. > Looking at this again, now that we use the hierarchy irqdomain, GIC no longer needs to be handling with children v2m. I'll remove this altogether. Suravee From mboxrd@z Thu Jan 1 00:00:00 1970 From: suravee.suthikulpanit@amd.com (Suravee Suthikulanit) Date: Mon, 3 Nov 2014 13:57:36 -0600 Subject: [V9 PATCH 2/2] irqchip: gicv2m: Add supports for ARM GICv2m MSI(-X) In-Reply-To: <54574FF7.706@arm.com> References: <1414743990-28421-1-git-send-email-suravee.suthikulpanit@amd.com> <1414743990-28421-3-git-send-email-suravee.suthikulpanit@amd.com> <54574FF7.706@arm.com> Message-ID: <5457DE30.3010200@amd.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/3/2014 3:50 AM, Marc Zyngier wrote: >> diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c >> >index a99c211..4069eb3 100644 >> >--- a/drivers/irqchip/irq-gic.c >> >+++ b/drivers/irqchip/irq-gic.c >> >@@ -46,6 +46,7 @@ >> > #include >> > >> > #include "irq-gic-common.h" >> >+#include "irq-gic-v2m.h" >> > #include "irqchip.h" >> > >> > union gic_base { >> >@@ -68,6 +69,9 @@ struct gic_chip_data { >> > #ifdef CONFIG_GIC_NON_BANKED >> > void __iomem *(*get_base)(union gic_base *); >> > #endif >> >+#ifdef CONFIG_ARM_GIC_V2M >> >+ struct list_head v2m_list; >> >+#endif > Can't that be something private to the v2m widget driver? I don't think > it brings anything to the main GIC driver. > Looking at this again, now that we use the hierarchy irqdomain, GIC no longer needs to be handling with children v2m. I'll remove this altogether. Suravee