All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6/6] manual: Various tidy changes
Date: Mon, 03 Nov 2014 22:10:34 +0100	[thread overview]
Message-ID: <5457EF4A.6050807@mind.be> (raw)
In-Reply-To: <1414971595-9972-6-git-send-email-maxime.hadjinlian@gmail.com>

On 03/11/14 00:39, Maxime Hadjinlian wrote:
> Changes performed all over the manual:
>     - In AsciiDoc, you only need 4 dashes to make a code block.
>     - Remove trailing spaces.
>     - Adding '// vim: set syntax=asciidoc:' when missing.
>     - Adding empty lines were needed.
>     - When an example of an external command is done, harmoize the use
>       of the scheme:
>       ' $ cmd'
> 
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>

 Seriously, are you combining 5 distinct changes into a 400-line patch? This
doesn't stand a chance of getting reviewed...

 Regards,
 Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2014-11-03 21:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-02 23:39 [Buildroot] [PATCH 1/6] dbus: Remove DBUS_USERS duplicate Maxime Hadjinlian
2014-11-02 23:39 ` [Buildroot] [PATCH 2/6] package/*/*.mk: Fix indent Maxime Hadjinlian
2014-11-03 20:58   ` Arnout Vandecappelle
2014-11-08 22:07   ` Peter Korsgaard
2014-11-02 23:39 ` [Buildroot] [PATCH 3/6] " Maxime Hadjinlian
2014-11-03 21:02   ` Arnout Vandecappelle
2014-11-02 23:39 ` [Buildroot] [PATCH 4/6] makedevs: Rework README Maxime Hadjinlian
2014-11-02 23:39 ` [Buildroot] [PATCH 5/6] manual: Rework makedevs syntax Maxime Hadjinlian
2014-11-02 23:39 ` [Buildroot] [PATCH 6/6] manual: Various tidy changes Maxime Hadjinlian
2014-11-03 21:10   ` Arnout Vandecappelle [this message]
2014-11-03 21:58     ` Maxime Hadjinlian
2014-11-03  9:08 ` [Buildroot] [PATCH 1/6] dbus: Remove DBUS_USERS duplicate Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5457EF4A.6050807@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.