From: hejianet <hejianet@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: Fix coding style space related ERROR problems
Date: Tue, 04 Nov 2014 09:13:59 +0800 [thread overview]
Message-ID: <54582857.2020406@gmail.com> (raw)
In-Reply-To: <20141104002557.GA19472@kroah.com>
Hi Greg
Sorry for the inconvience.
Seems I generated the patch @ your master branch instead of staging-test.
I will rebase it later.
B.R.
Justin
On Mon, 3 Nov 2014 16:25:57 -0800 from gregkh@linuxfoundation.org wrote:
> On Fri, Oct 31, 2014 at 10:07:15AM +0800, Jia He wrote:
>> This fixes space related ERROR reports by checkpatch.pl
>> Generated by $ git ls-files "drivers/staging/rtl8188eu/*.[ch]" | \
>> xargs ./scripts/checkpatch.pl -f --fix-inplace --strict --types=SPACING
>> Already checked by text comparasion
>> $git diff -w
>> and binary comparasion of r8188eu.ko
>> $objdiff diff <old_commit> <new_commit>
>>
>> Signed-off-by: Jia He <hejianet@gmail.com>
> Doesn't apply to my tree at all:
>
> checking file drivers/staging/rtl8188eu/core/rtw_cmd.c
> Hunk #1 succeeded at 637 (offset -1 lines).
> checking file drivers/staging/rtl8188eu/core/rtw_ieee80211.c
> checking file drivers/staging/rtl8188eu/core/rtw_mlme.c
> Hunk #1 succeeded at 2115 (offset -2 lines).
> checking file drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> checking file drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> Reversed (or previously applied) patch detected! Assume -R? [n]
> Apply anyway? [n]
> Skipping patch.
> 1 out of 1 hunk ignored
> checking file drivers/staging/rtl8188eu/core/rtw_recv.c
> checking file drivers/staging/rtl8188eu/core/rtw_security.c
> checking file drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> checking file drivers/staging/rtl8188eu/core/rtw_xmit.c
> checking file drivers/staging/rtl8188eu/hal/bb_cfg.c
> Reversed (or previously applied) patch detected! Assume -R? [n]
> Apply anyway? [n]
> Skipping patch.
> 2 out of 2 hunks ignored
> checking file drivers/staging/rtl8188eu/hal/fw.c
> checking file drivers/staging/rtl8188eu/hal/mac_cfg.c
> checking file drivers/staging/rtl8188eu/hal/odm.c
> checking file drivers/staging/rtl8188eu/hal/odm_HWConfig.c
> checking file drivers/staging/rtl8188eu/hal/odm_RTL8188E.c
> checking file drivers/staging/rtl8188eu/hal/phy.c
> checking file drivers/staging/rtl8188eu/hal/rf.c
> checking file drivers/staging/rtl8188eu/hal/rf_cfg.c
> checking file drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
> Hunk #1 succeeded at 252 (offset -2 lines).
> checking file drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
> checking file drivers/staging/rtl8188eu/hal/usb_halinit.c
> checking file drivers/staging/rtl8188eu/include/ieee80211_ext.h
> checking file drivers/staging/rtl8188eu/include/odm_debug.h
> Hunk #1 FAILED at 125.
> 1 out of 1 hunk FAILED
> checking file drivers/staging/rtl8188eu/include/osdep_service.h
> checking file drivers/staging/rtl8188eu/include/rtw_debug.h
> checking file drivers/staging/rtl8188eu/include/rtw_led.h
> checking file drivers/staging/rtl8188eu/include/rtw_mlme_ext.h
> checking file drivers/staging/rtl8188eu/include/wifi.h
> checking file drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> checking file drivers/staging/rtl8188eu/os_dep/os_intfs.c
> checking file drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
> checking file drivers/staging/rtl8188eu/os_dep/xmit_linux.c
>
>
>
next prev parent reply other threads:[~2014-11-04 1:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 8:47 [PATCH] staging: rtl8188eu: Fix coding style space related ERROR problems Jia He
2014-10-13 9:13 ` Joe Perches
2014-10-14 3:28 ` [PATCHv2] " Jia He
2014-10-14 4:48 ` Jia He
2014-10-17 5:31 ` hejianet
2014-10-17 5:54 ` Dan Carpenter
2014-10-17 8:06 ` Greg Kroah-Hartman
2014-10-29 8:45 ` Greg Kroah-Hartman
2014-10-30 15:21 ` [PATCHv3] " Jia He
2014-10-30 15:29 ` Greg Kroah-Hartman
2014-11-03 4:47 ` hejianet
2014-10-31 2:07 ` [PATCH] " Jia He
2014-11-04 0:25 ` Greg Kroah-Hartman
2014-11-04 1:13 ` hejianet [this message]
2014-11-04 1:39 ` Jia He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54582857.2020406@gmail.com \
--to=hejianet@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.