From: Alexandre Courbot <acourbot@nvidia.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors
Date: Tue, 4 Nov 2014 12:10:41 +0900 [thread overview]
Message-ID: <545843B1.3020101@nvidia.com> (raw)
In-Reply-To: <1414755658-96293-1-git-send-email-mika.westerberg@linux.intel.com>
On 10/31/2014 08:40 PM, Mika Westerberg wrote:
> Commit 21f2aae91e902aad ("leds: leds-gpio: Add support for GPIO
> descriptors") already converted most of the driver to use GPIO descriptors.
> What is still missing is the platform specific hook gpio_blink_set() and
> board files which pass legacy GPIO numbers to this driver in platform data.
>
> In this patch we handle the former and convert gpio_blink_set() to take
> GPIO descriptor instead. In order to do this we convert the existing four
> users to accept GPIO descriptor and translate it to legacy GPIO number in
> the platform code. This effectively "pushes" legacy GPIO number usage from
> the driver to platforms.
>
> Also add comment to the remaining block describing that it is legacy code
> path and we are getting rid of it eventually.
>
> Suggested-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
WARNING: multiple messages have this Message-ID (diff)
From: acourbot@nvidia.com (Alexandre Courbot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors
Date: Tue, 4 Nov 2014 12:10:41 +0900 [thread overview]
Message-ID: <545843B1.3020101@nvidia.com> (raw)
In-Reply-To: <1414755658-96293-1-git-send-email-mika.westerberg@linux.intel.com>
On 10/31/2014 08:40 PM, Mika Westerberg wrote:
> Commit 21f2aae91e902aad ("leds: leds-gpio: Add support for GPIO
> descriptors") already converted most of the driver to use GPIO descriptors.
> What is still missing is the platform specific hook gpio_blink_set() and
> board files which pass legacy GPIO numbers to this driver in platform data.
>
> In this patch we handle the former and convert gpio_blink_set() to take
> GPIO descriptor instead. In order to do this we convert the existing four
> users to accept GPIO descriptor and translate it to legacy GPIO number in
> the platform code. This effectively "pushes" legacy GPIO number usage from
> the driver to platforms.
>
> Also add comment to the remaining block describing that it is legacy code
> path and we are getting rid of it eventually.
>
> Suggested-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Courbot <acourbot@nvidia.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors
Date: Tue, 4 Nov 2014 12:10:41 +0900 [thread overview]
Message-ID: <545843B1.3020101@nvidia.com> (raw)
In-Reply-To: <1414755658-96293-1-git-send-email-mika.westerberg@linux.intel.com>
On 10/31/2014 08:40 PM, Mika Westerberg wrote:
> Commit 21f2aae91e902aad ("leds: leds-gpio: Add support for GPIO
> descriptors") already converted most of the driver to use GPIO descriptors.
> What is still missing is the platform specific hook gpio_blink_set() and
> board files which pass legacy GPIO numbers to this driver in platform data.
>
> In this patch we handle the former and convert gpio_blink_set() to take
> GPIO descriptor instead. In order to do this we convert the existing four
> users to accept GPIO descriptor and translate it to legacy GPIO number in
> the platform code. This effectively "pushes" legacy GPIO number usage from
> the driver to platforms.
>
> Also add comment to the remaining block describing that it is legacy code
> path and we are getting rid of it eventually.
>
> Suggested-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
next prev parent reply other threads:[~2014-11-04 3:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 11:40 [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors Mika Westerberg
2014-10-31 11:40 ` Mika Westerberg
2014-10-31 13:41 ` Andrew Lunn
2014-10-31 13:41 ` Andrew Lunn
2014-11-03 13:45 ` Linus Walleij
2014-11-03 13:45 ` Linus Walleij
2014-11-04 3:10 ` Alexandre Courbot [this message]
2014-11-04 3:10 ` Alexandre Courbot
2014-11-04 3:10 ` Alexandre Courbot
2014-11-04 22:50 ` Rafael J. Wysocki
2014-11-04 22:50 ` Rafael J. Wysocki
2014-11-06 9:52 ` Geert Uytterhoeven
2014-11-06 9:52 ` Geert Uytterhoeven
2014-11-06 9:52 ` Geert Uytterhoeven
2014-11-06 10:30 ` Mika Westerberg
2014-11-06 10:30 ` Mika Westerberg
2014-11-06 10:30 ` Mika Westerberg
2014-11-06 10:32 ` Geert Uytterhoeven
2014-11-06 10:32 ` Geert Uytterhoeven
2014-11-06 10:32 ` Geert Uytterhoeven
2014-11-06 10:58 ` Mika Westerberg
2014-11-06 10:58 ` Mika Westerberg
2014-11-06 10:58 ` Mika Westerberg
2014-11-06 11:12 ` Geert Uytterhoeven
2014-11-06 11:12 ` Geert Uytterhoeven
2014-11-06 11:12 ` Geert Uytterhoeven
2014-11-06 11:22 ` Mika Westerberg
2014-11-06 11:22 ` Mika Westerberg
2014-11-06 11:22 ` Mika Westerberg
2014-11-06 11:27 ` Geert Uytterhoeven
2014-11-06 11:27 ` Geert Uytterhoeven
2014-11-06 11:27 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545843B1.3020101@nvidia.com \
--to=acourbot@nvidia.com \
--cc=andrew@lunn.ch \
--cc=ben-linux@fluff.org \
--cc=cooloney@gmail.com \
--cc=jason@lakedaemon.net \
--cc=kgene.kim@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.