Re: [Qemu-devel] [PATCH v2] smbios: changed for "smbios_build_type_17_table()" to take 'uint64_t'

[Paolo Bonzini <pbonzini@redhat.com>]

On 04/11/2014 08:12, SeokYeon Hwang wrote:
> "smbios_build_type_17_table()" should take 'uint64_t' instead of 'ram_addr_t' because it should be able to handle (16ll * GiB).
> Otherwise, clang (>= 3.4) produces compilation warning in "smbios_get_tables()".
> 
> Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
> ---
>  hw/i386/smbios.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c
> index 8a7ad48..4ad42ae 100644
> --- a/hw/i386/smbios.c
> +++ b/hw/i386/smbios.c
> @@ -669,7 +669,7 @@ static void smbios_build_type_16_table(unsigned dimm_cnt)
>  #define MAX_T17_STD_SZ 0x7FFF /* (32G - 1M), in Megabytes */
>  #define MAX_T17_EXT_SZ 0x80000000 /* 2P, in Megabytes */
>  
> -static void smbios_build_type_17_table(unsigned instance, ram_addr_t size)
> +static void smbios_build_type_17_table(unsigned instance, uint64_t size)
>  {
>      char loc_str[128];
>      ram_addr_t size_mb;
> 

Can you make a patch that replaces _all_ occurrences in hw/i386/smbios.c
instead?

Thanks,

Paolo