From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v2 for-4.5] xen: Bump Xen interface for Xen-4.5 Date: Tue, 04 Nov 2014 12:00:39 +0000 Message-ID: <5458CDF70200007800044C30@mail.emea.novell.com> References: <5458BCA9.3000304@citrix.com> <1415101802-24096-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1415101802-24096-1-git-send-email-andrew.cooper3@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Keir Fraser , Ian Campbell , Ian Jackson , Tim Deegan , Xen-devel List-Id: xen-devel@lists.xenproject.org >>> On 04.11.14 at 12:50, wrote: > c/s fce5281c "x86/mem_access: Deprecate the HVM mem_access ops" removes the > structures associated with xen_hvm_{get,set}_mem_access from the Xen public > API. > > While these were toolstack hypercalls and documented as liable to change in > the future, it causes build issues for certain tools (valgrind, strace). > > As HVM ops have no specific interface version, the main Xen interface > version > needs to be bumped to compensate. Content-wise I don't really object to this patch, but I view it as merely cosmetic rather than fixing anything: Tool stack interfaces are declared to be volatile just because we want to avoid exactly this need for bumping versions or anything when altering or dropping them. If there are out of tree consumers of them, it is their responsibility to keep up with our changes (or have their own clones of the canonical headers). Also we didn't bother incrementing the version just because of a release on earlier occasions: 3.3 and 3.4 as well as 4.0 and 4.1 shared interface versions, yet especially in the case of 4.1 I'm pretty certain even without explicitly checking that there were tool stack interface changes. Jan