From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Longerbeam Subject: Re: [PATCH 19/72] gpu: ipu-v3: Protect more CM reg access with IPU lock Date: Tue, 04 Nov 2014 17:54:59 -0800 Message-ID: <54598373.9070904@gmail.com> References: <1414796095-10107-1-git-send-email-steve_longerbeam@mentor.com> <1414796095-10107-20-git-send-email-steve_longerbeam@mentor.com> <1415123510.3701.23.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-la0-f43.google.com (mail-la0-f43.google.com [209.85.215.43]) by gabe.freedesktop.org (Postfix) with ESMTP id B56D86E0B7 for ; Tue, 4 Nov 2014 17:55:05 -0800 (PST) Received: by mail-la0-f43.google.com with SMTP id ge10so2005442lab.16 for ; Tue, 04 Nov 2014 17:55:04 -0800 (PST) In-Reply-To: <1415123510.3701.23.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philipp Zabel Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gMTEvMDQvMjAxNCAwOTo1MSBBTSwgUGhpbGlwcCBaYWJlbCB3cm90ZToKPiBIaSBTdGV2ZSwK Pgo+IEFtIEZyZWl0YWcsIGRlbiAzMS4xMC4yMDE0LCAxNTo1NCAtMDcwMCBzY2hyaWViIFN0ZXZl IExvbmdlcmJlYW06Cj4+IFNvbWUgY21fcmVnIGFjY2Vzc2VzIHdlcmUgbm90IGJlaW5nIHByb3Rl Y3RlZCBieSB0aGUgSVBVIHNwaW4gbG9jay4KPj4KPj4gU2lnbmVkLW9mZi1ieTogU3RldmUgTG9u Z2VyYmVhbSA8c3RldmVfbG9uZ2VyYmVhbUBtZW50b3IuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMv Z3B1L2lwdS12My9pcHUtY29tbW9uLmMgfCAgIDIyICsrKysrKysrKysrKysrKysrKysrLS0KPj4g IDEgZmlsZSBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+Pgo+PiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvaXB1LXYzL2lwdS1jb21tb24uYyBiL2RyaXZlcnMvZ3B1 L2lwdS12My9pcHUtY29tbW9uLmMKPj4gaW5kZXggZjcwN2QyNS4uZDNhZjIwNiAxMDA2NDQKPj4g LS0tIGEvZHJpdmVycy9ncHUvaXB1LXYzL2lwdS1jb21tb24uYwo+PiArKysgYi9kcml2ZXJzL2dw dS9pcHUtdjMvaXB1LWNvbW1vbi5jCj4+IEBAIC00NiwxMSArNDYsMTYgQEAgc3RhdGljIGlubGlu ZSB2b2lkIGlwdV9jbV93cml0ZShzdHJ1Y3QgaXB1X3NvYyAqaXB1LCB1MzIgdmFsdWUsIHVuc2ln bmVkIG9mZnNldCkKPj4gIAo+PiAgdm9pZCBpcHVfc3JtX2RwX3N5bmNfdXBkYXRlKHN0cnVjdCBp cHVfc29jICppcHUpCj4+ICB7Cj4+ICsJdW5zaWduZWQgbG9uZyBmbGFnczsKPj4gIAl1MzIgdmFs Owo+PiAgCj4+ICsJc3Bpbl9sb2NrX2lycXNhdmUoJmlwdS0+bG9jaywgZmxhZ3MpOwo+PiArCj4+ ICAJdmFsID0gaXB1X2NtX3JlYWQoaXB1LCBJUFVfU1JNX1BSSTIpOwo+PiAgCXZhbCB8PSAweDg7 Cj4+ICAJaXB1X2NtX3dyaXRlKGlwdSwgdmFsLCBJUFVfU1JNX1BSSTIpOwo+PiArCj4+ICsJc3Bp bl91bmxvY2tfaXJxcmVzdG9yZSgmaXB1LT5sb2NrLCBmbGFncyk7Cj4+ICB9Cj4+ICBFWFBPUlRf U1lNQk9MX0dQTChpcHVfc3JtX2RwX3N5bmNfdXBkYXRlKTsKPiBUaGlzIGlzIHRoZSBvbmx5IHBs YWNlIHRoaXMgcmVnaXN0ZXIgdG91Y2hlZCwgb25seSBiaXQgMyBpcyBldmVyIGVuYWJsZWQKPiBi eSBzb2Z0d2FyZS4gVGhpcyBsb2NrIGlzIG5vdCBuZWVkZWQuCgp5ZXMsIEkgdmVyaWZpZWQgdGhh dCB0b28uIE5ldmVyIG1pbmQgdGhlbi4KCj4+IEBAIC00NTEsOCArNDU2LDE3IEBAIGludCBpcHVf aWRtYWNfZ2V0X2N1cnJlbnRfYnVmZmVyKHN0cnVjdCBpcHV2M19jaGFubmVsICpjaGFubmVsKQo+ PiAgewo+PiAgCXN0cnVjdCBpcHVfc29jICppcHUgPSBjaGFubmVsLT5pcHU7Cj4+ICAJdW5zaWdu ZWQgaW50IGNobm8gPSBjaGFubmVsLT5udW07Cj4+ICsJdW5zaWduZWQgbG9uZyBmbGFnczsKPj4g KwlpbnQgcmV0Owo+PiArCj4+ICsJc3Bpbl9sb2NrX2lycXNhdmUoJmlwdS0+bG9jaywgZmxhZ3Mp Owo+PiAgCj4+IC0JcmV0dXJuIChpcHVfY21fcmVhZChpcHUsIElQVV9DSEFfQ1VSX0JVRihjaG5v KSkgJiBpZG1hX21hc2soY2hubykpID8gMSA6IDA7Cj4+ICsJcmV0ID0gKGlwdV9jbV9yZWFkKGlw dSwgSVBVX0NIQV9DVVJfQlVGKGNobm8pKSAmIGlkbWFfbWFzayhjaG5vKSkgPwo+PiArCQkxIDog MDsKPj4gKwo+PiArCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmlwdS0+bG9jaywgZmxhZ3MpOwo+ PiArCj4+ICsJcmV0dXJuIHJldDsKPiBEaXRvLiBUaGlzIHJlZ2lzdGVyIGlzbid0IHdyaXR0ZW4g cGFydGlhbGx5IG11bHRpcGxlIHRpbWVzIHVuZGVyIHRoZQo+IHNwaW5sb2NrIGFueXdoZXJlLCBz byB0aGVyZSBpcyBubyBnYWluIGZyb20gdGhpcyBsb2NrIGFyb3VuZCBhIHJlZ2lzdGVyCj4gcmVh ZC4KCldlbGwsIEkgd2FzIHRoaW5raW5nIGdldF9jdXJyZW50X2J1ZmZlciBjb3VsZCByYWNlIHdp dGgKcmVzZXRfY3VycmVudF9idWZmZXIsIGJ1dCB0aGVzZSBmdW5jdGlvbnMgYXJlIGRvaW5nIHBs YWluCnJlYWRsKCkgYW5kIHdyaXRlbCgpIChpLmUuIG5vdCByZWFkLW1vZGlmeS13cml0ZSksIHNv IHRoZXkKYXJlIGF0b21pYyBvcGVyYXRpb25zLiBTbyBuZXZlciBtaW5kIHRoaXMgZWl0aGVyLgoK Pj4gIH0KPj4gIEVYUE9SVF9TWU1CT0xfR1BMKGlwdV9pZG1hY19nZXRfY3VycmVudF9idWZmZXIp Owo+PiAgCj4+IEBAIC01NjksMTAgKzU4MywxNCBAQCBFWFBPUlRfU1lNQk9MX0dQTChpcHVfaWRt YWNfd2FpdF9idXN5KTsKPj4gIAo+PiAgaW50IGlwdV93YWl0X2ludGVycnVwdChzdHJ1Y3QgaXB1 X3NvYyAqaXB1LCBpbnQgaXJxLCBpbnQgbXMpCj4+ICB7Cj4+IC0JdW5zaWduZWQgbG9uZyB0aW1l b3V0Owo+PiArCXVuc2lnbmVkIGxvbmcgZmxhZ3MsIHRpbWVvdXQ7Cj4+ICAKPj4gIAl0aW1lb3V0 ID0gamlmZmllcyArIG1zZWNzX3RvX2ppZmZpZXMobXMpOwo+PiArCj4+ICsJc3Bpbl9sb2NrX2ly cXNhdmUoJmlwdS0+bG9jaywgZmxhZ3MpOwo+PiAgCWlwdV9jbV93cml0ZShpcHUsIEJJVChpcnEg JSAzMiksIElQVV9JTlRfU1RBVChpcnEgLyAzMikpOwo+PiArCXNwaW5fdW5sb2NrX2lycXJlc3Rv cmUoJmlwdS0+bG9jaywgZmxhZ3MpOwo+PiArCj4+ICAJd2hpbGUgKCEoaXB1X2NtX3JlYWQoaXB1 LCBJUFVfSU5UX1NUQVQoaXJxIC8gMzIpICYgQklUKGlycSAlIDMyKSkpKSB7Cj4+ICAJCWlmICh0 aW1lX2FmdGVyKGppZmZpZXMsIHRpbWVvdXQpKQo+PiAgCQkJcmV0dXJuIC1FVElNRURPVVQ7Cj4g VGhpcyBpcyBhIHdyaXRlIHRvIGNsZWFyIHJlZ2lzdGVyLCB0aGUgb25seSBvdGhlciBwbGFjZSBp dCBpcyBhY2Nlc3NlZAo+IGlzIGJ5IHRoZSByZWdtYXAgaXJxIGhhbmRsZXIuIENhbiB5b3UgdGhp bmsgb2YgYSBzY2VuYXJpbyB3aGVyZSB0aGlzCj4gbG9jayB3b3VsZCBwcm90ZWN0IGFueXRoaW5n PwoKSW4gdGhpcyBjYXNlIEkgZG8gc2VlIHBvdGVudGlhbCBwcm9ibGVtcy4gV2hhdCBpZiB0aHJl YWQgQSBjYWxscwppcHVfd2FpdF9pbnRlcnJ1cHQoKSB3aGlsZSB0aHJlYWQgQiBpcyBjdXJyZW50 bHkgbG9vcGluZyB0aHJvdWdoCmlycSBzdGF0dXMgYml0cyBpbiBpcHVfaXJxX2hhbmRsZSgpPyBB IGhhcyBub3cgY2xlYXJlZCBhbiBpcnEgc3RhdHVzCmJlZm9yZSBCIGhhcyBoYWQgYSBjaGFuY2Ug dG8gZ2V0IHRvIHRoYXQgc3RhdHVzIGJpdC4gVGh1cyB0aGUgaXJxCnN0YXR1cyBpcyBtaXNzZWQg YW5kIHRoZSBpcnEgbm90IGhhbmRsZWQuIFRoYXQgYmVpbmcgc2FpZCB0aGlzIHBhdGNoCndpbGwg bm90IGZpeCB0aGUgcHJvYmxlbSBiZWNhdXNlIGlwdV93YWl0X2ludGVycnVwdCgpIGFuZCBpcHVf aXJxX2hhbmRsZSgpCmFyZSB1bmRlciBkaWZmZXJlbnQgbG9ja3MuCgpNYXliZSB0aGUgc29sdXRp b24gaXMgdG8gdmVyaWZ5IGlwdV93YWl0X2ludGVycnVwdCgpIGlzIG5ldmVyIGNhbGxlZApvbiBl bmFibGVkIGlycXMgc28gdGhhdCBpdCBkb2Vzbid0IGludGVyZmVyZSB3aXRoIGlycSBoYW5kbGlu Zy4gQnV0IEkKZG9uJ3Qga25vdyB0aGF0IHRoYXQgaXMgdHJ1ZSwgaXMgaXQ/CgpTdGV2ZQoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==