From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH 0/2] make imx hdmi publicly used by dw hdmi compatible platform Date: Wed, 05 Nov 2014 10:12:13 +0800 Message-ID: <5459877D.2080606@rock-chips.com> References: <1415107992-34289-1-git-send-email-andy.yan@rock-chips.com> <20141104142908.GG4042@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20141104142908.GG4042@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Russell King - ARM Linux Cc: heiko@sntech.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Arnd Bergmann , Inki Dae , Rob Herring , Sean Paul , fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Philipp Zabel , Shawn Guo , Lucas Stach List-Id: devicetree@vger.kernel.org Ck9uIDIwMTTlubQxMeaciDA05pelIDIyOjI5LCBSdXNzZWxsIEtpbmcgLSBBUk0gTGludXggd3Jv dGU6Cj4gT24gVHVlLCBOb3YgMDQsIDIwMTQgYXQgMDk6MzM6MTBQTSArMDgwMCwgQW5keSBZYW4g d3JvdGU6Cj4+IEZyb206IEFuZHkgeWFuIDxhbmR5LnlhbkByb2NrLWNoaXBzLmNvbT4KPj4KPj4g V2UgZm91bmQgZnJlZXNjYWxlIGlteDYgYW5kIHJvY2tjaGlwIHJrMzI4OCBhbmQgSW5nZW5pYyBK WjQ3ODAgKFhidXJzdC9NSVBTKQo+PiB1c2UgdGhlIGludGVyZmFjZSBjb21wYXRpYmxlIERlc2ln bndhcmUgSERNSSBJUCwgYnV0IHRoZXkgYWxzbyBoYXZlIHNvbWUKPj4gbGlnaHRseSBkaWZmZXJl bmNlLCBzdWNoIGFzIHBoeSBwbGwgY29uZmlndXJhdGlvbiwgcmVnaXN0ZXIgd2lkdGgoaW14IGhk bWkKPj4gcmVnaXN0ZXIgaXMgb25lIGJ5dGUsIGJ1dCByazMyODggaXMgNCBieXRlcyB3aWR0aCBh bmQgY2FuIG9ubHkgYWNjZXNzIGJ5IHdvcmQpLAo+PiA0SyBzdXBwb3J0KGlteDYgZG9lc24ndCBz dXBwb3J0IDRrLCBidXQgcmszMjg4IGRvZXMpLgo+Pgo+PiBUbyByZXVzZSB0aGUgaW14LWhkbWkg ZHJpdmVyLCB3ZSBkbyB0aGlzIHBhdGNoIHNldDoKPj4gcGF0Y2ggKDEpOiBzcGxpdCBvdXQgaW14 LXNvYyBjb2RlIGZyb20gaW14LWhkbWkgdG8gZHdfaGRtaS1pbXguYwo+PiBwYXRjaCAoMik6IG1v dmUgaW14LWhkbWkgdG8gYnJpZGdlLywgYW5kIHJlbmFtZSB0byBkdy1oZG1pIHRvCj4+IG1ha2Ug dGhpcyBkcml2ZXIgaW5kZXBlbnQgb2YgZHJtLWlteCAuIEFuZCB3ZSB3aWxsIGFkZCByb2NrY2hp cAo+PiBwbGF0Zm9ybSBzcGVjaWZpYyBjb2RlIGR3X2hkbWktcm9ja2NoaXAuYyBsYXRlciwgdGhp cyBpcyBkZXBlbmQKPj4gb24gZHJtLXJvY2tjaGlwLgo+IEdyZWF0IC0gSSBmdWxseSBhZ3JlZSB0 aGF0IHRoaXMgbmVlZHMgdG8gYmUgcmVuYW1lZCBhcyBpdCBpcyBhIERlc2lnbndhcmUKPiBJUC4K Pgo+IFNob3VsZCBpdCBiZSBtb3ZlZCBpbnRvIGJyaWRnZS8gPyAgSXQgaXNuJ3QgaW1wbGVtZW50 ZWQgYXMgYSBEUk0gYnJpZGdlCj4gZHJpdmVyIGF0IHByZXNlbnQsIHNvIHRoaXMgc2VlbXMgaWxs b2dpY2FsLiAgSXMgdGhlIGxvbmdlciB0ZXJtIHBsYW4gdG8KPiBjb252ZXJ0IGl0IHRvIGJlIGEg RFJNIGJyaWRnZT8KV2UgaGF2ZSBwbGFuIHRvIGNvbnZlcnQgaXQgdG8gRFJNIGJyaWRnZS4KPgo+ IFNlY29uZGx5LCBpZiB5b3Ugd2FudCBIRE1JIGF1ZGlvIHN1cHBvcnQsIHlvdSBtYXkgZmluZCB0 aGUgcGF0Y2hlcyBJCj4gbWFpbnRhaW4gZm9yIHRoZSBTb2xpZFJ1biBkZXZpY2VzIHVzZWZ1bCwg d2hpY2ggYWRkIHRoaXMgYXMgYSBzdGFuZGFyZAo+IEFMU0EgZGV2aWNlLiAgSSBhbHNvIGhhdmUg Q0VDIHN1cHBvcnQgZm9yIGl0IGFzIHdlbGwuICBJZiB5b3UncmUKPiBpbnRlcmVzdGVkLCBJJ2xs IGVtYWlsIHRob3NlLgo+Ckl0J3MgdmVyeSBncmVhdCBpZiB5b3UgZW1haWwgdGhvc2UsIHdlIGFy ZSBhbHNvIHdvcmtpbmcgb24gYXVkaW8gYW5kIENFQy4KCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRldmVsIG1haWxpbmcgbGlzdApkZXZlbEBsaW51eGRy aXZlcnByb2plY3Qub3JnCmh0dHA6Ly9kcml2ZXJkZXYubGludXhkcml2ZXJwcm9qZWN0Lm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaXZlcmRldi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752712AbaKECMd (ORCPT ); Tue, 4 Nov 2014 21:12:33 -0500 Received: from va-smtp01.263.net ([54.88.144.211]:34057 "EHLO va-smtp01.263.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751506AbaKECMb (ORCPT ); Tue, 4 Nov 2014 21:12:31 -0500 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: linux-rockchip@lists.infradead.org X-SENDER-IP: 199.193.78.101 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: X-DNS-TYPE: 0 Message-ID: <5459877D.2080606@rock-chips.com> Date: Wed, 05 Nov 2014 10:12:13 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Russell King - ARM Linux CC: airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, Greg Kroah-Hartman , Grant Likely , Rob Herring , Philipp Zabel , Shawn Guo , Josh Boyer , Sean Paul , Inki Dae , Dave Airlie , Arnd Bergmann , Lucas Stach , Zubair.Kakakhel@imgtec.com, djkurtz@google.com, ykk@rock-chips.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 0/2] make imx hdmi publicly used by dw hdmi compatible platform References: <1415107992-34289-1-git-send-email-andy.yan@rock-chips.com> <20141104142908.GG4042@n2100.arm.linux.org.uk> In-Reply-To: <20141104142908.GG4042@n2100.arm.linux.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014年11月04日 22:29, Russell King - ARM Linux wrote: > On Tue, Nov 04, 2014 at 09:33:10PM +0800, Andy Yan wrote: >> From: Andy yan >> >> We found freescale imx6 and rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS) >> use the interface compatible Designware HDMI IP, but they also have some >> lightly difference, such as phy pll configuration, register width(imx hdmi >> register is one byte, but rk3288 is 4 bytes width and can only access by word), >> 4K support(imx6 doesn't support 4k, but rk3288 does). >> >> To reuse the imx-hdmi driver, we do this patch set: >> patch (1): split out imx-soc code from imx-hdmi to dw_hdmi-imx.c >> patch (2): move imx-hdmi to bridge/, and rename to dw-hdmi to >> make this driver indepent of drm-imx . And we will add rockchip >> platform specific code dw_hdmi-rockchip.c later, this is depend >> on drm-rockchip. > Great - I fully agree that this needs to be renamed as it is a Designware > IP. > > Should it be moved into bridge/ ? It isn't implemented as a DRM bridge > driver at present, so this seems illogical. Is the longer term plan to > convert it to be a DRM bridge? We have plan to convert it to DRM bridge. > > Secondly, if you want HDMI audio support, you may find the patches I > maintain for the SolidRun devices useful, which add this as a standard > ALSA device. I also have CEC support for it as well. If you're > interested, I'll email those. > It's very great if you email those, we are also working on audio and CEC.