From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Sven Eckelmann Subject: Re: [PATCH v2] batman-adv: bcast: queue per interface, if needed Date: Fri, 14 May 2021 13:52:17 +0200 Message-ID: <5459898.nmiLi0PJat@sven-desktop> In-Reply-To: <20210514113532.GF2222@otheros> References: <20210427184527.9889-1-linus.luessing@c0d3.blue> <3148825.KiqjeL1upR@sven-desktop> <20210514113532.GF2222@otheros> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart9607628.pxMfDq879Z"; micalg="pgp-sha512"; protocol="application/pgp-signature" Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: To: The list for a Better Approach To Mobile Ad-hoc Networking Cc: Linus =?ISO-8859-1?Q?L=FCssing?= --nextPart9607628.pxMfDq879Z Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; protected-headers="v1" From: Sven Eckelmann To: The list for a Better Approach To Mobile Ad-hoc Networking Cc: Linus =?ISO-8859-1?Q?L=FCssing?= Subject: Re: [PATCH v2] batman-adv: bcast: queue per interface, if needed Date: Fri, 14 May 2021 13:52:17 +0200 Message-ID: <5459898.nmiLi0PJat@sven-desktop> In-Reply-To: <20210514113532.GF2222@otheros> References: <20210427184527.9889-1-linus.luessing@c0d3.blue> <3148825.KiqjeL1upR@sven-desktop> <20210514113532.GF2222@otheros> On Friday, 14 May 2021 13:35:32 CEST Linus L=FCssing wrote: > On Fri, May 14, 2021 at 10:28:53AM +0200, Sven Eckelmann wrote: > > On Tuesday, 27 April 2021 20:45:27 CEST Linus L=FCssing wrote: > > > - * The skb is not consumed, so the caller should make sure that the > > > - * skb is freed. > > > + * This call clones the given skb, hence the caller needs to take in= to > > > + * account that the data segment of the original skb might not be > > > + * modifiable anymore. > >=20 > > But none of your callers is now taking care of it because you've remove= d all=20 > > skb_copy's. All you do is to clone the control data and give it to the= =20 > > underlying layers. And they may write freely to the data. Thus breaking= =20 > > parallel (and under some circumstances sequential) running code which o= perates=20 > > on the skbs. >=20 > Hi Sven, >=20 > Thanks for looking at it so far. I'm not quite sure if the > skb_copy() is needed though. Because there is a new skb_cow(). Let > me explain my thoughts: [...] Haven't checked this in detail. But please split this part in a separate pa= tch=20 with the corresponding explanation. Should make it easier to understand why= =20 the skb_copy is no longer needed. Kind regards, Sven --nextPart9607628.pxMfDq879Z Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAmCeZHEACgkQXYcKB8Em e0Y+FQ/9GBKQq5suuUlTjN2HXPF+KZGrdIxKICCgVepdTuPcx83CXVMda+gjebWM EGUB9wa/ed0IwGZJfu0CmVA4/FtBabKdJFpbe4o/3Fusoe5fTMnIg8dXK0idO95K kmqsXf74MGf3HbSCi4f3aDgyGgszcohHGCjh7q78OYps9yA/0aRWCraA8BL4FpHV /ga3lAwWQahb2kKTdLM4d8GY7JiGekBLcDE1k1jDdKLVqHzEesBdtkKH7j4/7In7 i2vCUykM3YodqPRWoMDS9nfzAKLHZMyht/uAPo+TFQNd/z5F5vjGYCdXV/VI8QBU 4jBcUleu7Cc5cnYg4gW7afMkP54dh9m68+JaWITx2DcrEzQwLi1s/Syt8yX28Oa8 aWsFUW1y6xQpuXDSHGzEYVqHzstjjl8NzCE5ViM4ytk3CA8PapWv1oCHP/BBHggj 2x4uOrJchyzhI+bBCCVtci+YyXaTwRJu0vWhgC6kayKvyGmO0teWPCe0lrYIsSE/ Mo+60QQvKHh3ud6RMMdJDiQMiiVMTs7lBq7z5mwx35qxYCIniV8A32iHoi8XnGDV vLnvT3tp2oKANDu6RlrKBrm1/GXHispZ5bK7IeCZ9GSpkYxNvEW1a8jIQYKG5N6r bC4BLJ4B3GQ3N1xd9pYXF1VhKkUImyC0s2IZ97GXxMEHMwEnPTE= =ZBUG -----END PGP SIGNATURE----- --nextPart9607628.pxMfDq879Z--