From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Zhu Subject: Re: [PATCH v3 00/10] split architecture specific operations Date: Wed, 05 Nov 2014 10:39:56 +0800 Message-ID: <54598DFC.6070006@linux.vnet.ibm.com> References: <1414500657-23774-1-git-send-email-david.marchand@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: bjzhuc-vtt25B2cwJLQT0dZR+AlfA@public.gmane.org To: David Marchand , dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1414500657-23774-1-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > The set of patches split x86 architecture specific operations from DPDK and put > them to x86 arch directory. > This will make the adoption of DPDK much easier on other computer architecture. > For a new architecture, just add an architecture specific directory and > necessary building configuration files, then DPDK eal library can support it. > > > Reviewing patchset from Chao, I ended up modifying it along the way, > so here is a new iteration of this patchset. > > Changes since Chao v2 patchset : > > - added a preliminary patch for moving rte_atomic.h (for better readability) > - fixed documentation generation > - implemented a generic header for each arch specific header (cpuflags, memcpy, > prefetch were missing) > - removed C++ stuff from generic headers > - centralised all doxygen stuff in generic headers (no need to have duplicates) > - refactored rte_cycles functions > - moved vmware tsc stuff to arch rte_cycles.h headers > - finished x86 factorisation > > > Little summary of current state : > > - all applications continue to include the eal headers as before, these headers > are the arch-specific ones > - the arch specific headers always include the generic ones. The generic headers > contain the doxygen documentation and code common to all architectures > - a x86 architecture has been defined which handles both 32bits and 64bits > peculiarities > > > It builds fine for 32/64 bits (w and w/o "force intrinsics"), but I really would > like a lot of eyes on this (and I would say, especially, rte_cycles, rte_memcpy > and rte_cpuflags). > I still have some concerns about the use of intrinsics for architecture != x86 > but I think Chao will be the best to look at this. > > Acked-by: Chao Zhu