From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] ubi: enable error reporting in initialization
Date: Wed, 05 Nov 2014 07:57:27 +0100 [thread overview]
Message-ID: <5459CA57.9090009@denx.de> (raw)
In-Reply-To: <1415117278-1255-1-git-send-email-andrew.ruder@elecsyscorp.com>
Hello Andrew,
Am 04.11.2014 17:07, schrieb Andrew Ruder:
> The UBI layer will disable much of its error reporting when it is
> compiled into the linux kernel to avoid stopping boot. We want this
> error reporting in U-Boot since we don't initialize the UBI layer until
> it is used and want the error reporting.
>
> We force this by telling the UBI layer we are building as a module.
>
> Signed-off-by: Andrew Ruder<andrew.ruder@elecsyscorp.com>
> Cc: Wolfgang Denk<wd@denx.de>
> Cc: Heiko Schocher<hs@denx.de>
> Cc: Kyungmin Park<kmpark@infradead.org>
> ---
> include/ubi_uboot.h | 2 ++
> 1 file changed, 2 insertions(+)
I posted such a question [1] on the ML ...
The problem is in generally enabling this feature in the size impact ...
This should be discussed if we want this for all boards ...
> diff --git a/include/ubi_uboot.h b/include/ubi_uboot.h
> index 1fd15f4..6ff0e23 100644
> --- a/include/ubi_uboot.h
> +++ b/include/ubi_uboot.h
> @@ -51,6 +51,8 @@
>
> #undef CONFIG_MTD_UBI_BLOCK
>
> +#define CONFIG_MTD_UBI_MODULE
> +
> #if !defined(CONFIG_MTD_UBI_BEB_LIMIT)
> #define CONFIG_MTD_UBI_BEB_LIMIT 20
> #endif
Ok, didn;t tried this with enabling "CONFIG_MTD_UBI_MODULE" ...
But the name CONFIG_MTD_UBI_MODULE is not perfect, if we want
just to enable error messages ...
bye,
Heiko
[1] http://patchwork.ozlabs.org/patch/405259/
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2014-11-05 6:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 16:07 [U-Boot] [PATCH 1/2] ubi: enable error reporting in initialization Andrew Ruder
2014-11-04 16:07 ` [U-Boot] [PATCH 2/2] mtd: nor: initialize writebufsize field Andrew Ruder
2014-11-05 7:00 ` Heiko Schocher
2014-11-05 19:23 ` Andrew Ruder
2014-11-06 7:07 ` Heiko Schocher
2014-11-05 6:57 ` Heiko Schocher [this message]
2014-11-05 14:27 ` [U-Boot] [PATCH 1/2] ubi: enable error reporting in initialization Andrew Ruder
2014-11-05 15:12 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5459CA57.9090009@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.