From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Karl Beldan <karl.beldan@gmail.com>,
David Miller <davem@davemloft.net>,
Ian Campbell <ijc@hellion.org.uk>
Cc: Karl Beldan <karl.beldan@rivierawaves.com>,
netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] net: mv643xx_eth: reclaim TX skbs only when released by the HW
Date: Wed, 05 Nov 2014 11:46:16 -0300 [thread overview]
Message-ID: <545A3838.3090606@free-electrons.com> (raw)
In-Reply-To: <1415197979-1702-1-git-send-email-karl.beldan@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]
Hi Karl,
On 11/05/2014 11:32 AM, Karl Beldan wrote:> From: Karl Beldan <karl.beldan@rivierawaves.com>
>
> ATM, txq_reclaim will dequeue and free an skb for each tx desc released
> by the hw that has TX_LAST_DESC set. However, in case of TSO, each
> hw desc embedding the last part of a segment has TX_LAST_DESC set,
> losing the one-to-one 'last skb frag'/'TX_LAST_DESC set' correspondance,
> which causes data corruption.
>
> Fix this by checking TX_ENABLE_INTERRUPT instead of TX_LAST_DESC, and
> warn when trying to dequeue from an empty txq (which can be symptomatic
> of releasing skbs prematurely).
>
> Fixes: 3ae8f4e0b98 ('net: mv643xx_eth: Implement software TSO')
Although your change makes sense, this isn't fixing the issue for me,
neither did the previous one.
Ian: Can you double check that you have corruption *without* the patch,
and that the patch fixes the issue?
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-05 14:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 14:32 [PATCH] net: mv643xx_eth: reclaim TX skbs only when released by the HW Karl Beldan
2014-11-05 14:46 ` Ezequiel Garcia [this message]
2014-11-05 15:05 ` Karl Beldan
2014-11-05 18:31 ` Karl Beldan
2014-11-05 15:41 ` Eric Dumazet
2014-11-05 19:04 ` Ian Campbell
2014-11-06 19:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545A3838.3090606@free-electrons.com \
--to=ezequiel.garcia@free-electrons.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ijc@hellion.org.uk \
--cc=karl.beldan@gmail.com \
--cc=karl.beldan@rivierawaves.com \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.