From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47057)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1Xm2Ry-0004NT-N8
	for qemu-devel@nongnu.org; Wed, 05 Nov 2014 10:24:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1Xm2Ru-0000jj-7F
	for qemu-devel@nongnu.org; Wed, 05 Nov 2014 10:24:46 -0500
Received: from mailapp01.imgtec.com ([195.59.15.196]:8727)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1Xm2Rt-0000jM-W2
	for qemu-devel@nongnu.org; Wed, 05 Nov 2014 10:24:42 -0500
Message-ID: <545A4132.9090608@imgtec.com>
Date: Wed, 5 Nov 2014 15:24:34 +0000
From: Leon Alrae <leon.alrae@imgtec.com>
MIME-Version: 1.0
References: <alpine.DEB.1.10.1411031811300.2881@tp.orcam.me.uk>
In-Reply-To: <alpine.DEB.1.10.1411031811300.2881@tp.orcam.me.uk>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] mips: Remove CONFIG_VT82C686 from
	non-Fulong configs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Maciej W. Rozycki" <macro@codesourcery.com>, qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>

On 03/11/2014 18:36, Maciej W. Rozycki wrote:
> Fix the regression introduced with commit 
> 47934d0aadc075b05ce2d9e8a44fa6a46edd1afa [hw: move ISA bridges and 
> devices to hw/isa/, configure with default-configs/], by removing 
> CONFIG_VT82C686 from configurations that previously did not enable it.  
> That southbridge is only available on Fulong platforms (CONFIG_FULONG) 
> that are exclusively little-endian, 64-bit MIPS.  Previously vt82c686.o 
> was pulled explicitly with obj-$(CONFIG_FULONG).
> 
> Signed-off-by: Maciej W. Rozycki <macro@codesourcery.com>
> ---
> Hi,
> 
>  Trivial stuff first, tougher later on.  Compile-tested only, this 
> addresses a regression and should be obviously correct.  Please apply.
> 
>  Thanks,
> 
>   Maciej
> 
> qemu-mipseb-fulong-vt82c686.diff
> Index: qemu-git-trunk/default-configs/mips-softmmu.mak
> ===================================================================
> --- qemu-git-trunk.orig/default-configs/mips-softmmu.mak	2014-03-01 02:45:51.000000000 +0000
> +++ qemu-git-trunk/default-configs/mips-softmmu.mak	2014-10-28 23:01:51.178971390 +0000
> @@ -32,6 +32,5 @@ CONFIG_G364FB=y
>  CONFIG_I8259=y
>  CONFIG_JAZZ_LED=y
>  CONFIG_MC146818RTC=y
> -CONFIG_VT82C686=y
>  CONFIG_ISA_TESTDEV=y
>  CONFIG_EMPTY_SLOT=y
> Index: qemu-git-trunk/default-configs/mips64-softmmu.mak
> ===================================================================
> --- qemu-git-trunk.orig/default-configs/mips64-softmmu.mak	2014-03-01 02:45:51.000000000 +0000
> +++ qemu-git-trunk/default-configs/mips64-softmmu.mak	2014-10-28 23:02:09.678926473 +0000
> @@ -32,6 +32,5 @@ CONFIG_G364FB=y
>  CONFIG_I8259=y
>  CONFIG_JAZZ_LED=y
>  CONFIG_MC146818RTC=y
> -CONFIG_VT82C686=y
>  CONFIG_ISA_TESTDEV=y
>  CONFIG_EMPTY_SLOT=y
> Index: qemu-git-trunk/default-configs/mipsel-softmmu.mak
> ===================================================================
> --- qemu-git-trunk.orig/default-configs/mipsel-softmmu.mak	2014-03-01 02:45:51.000000000 +0000
> +++ qemu-git-trunk/default-configs/mipsel-softmmu.mak	2014-10-28 23:02:26.677701438 +0000
> @@ -32,6 +32,5 @@ CONFIG_G364FB=y
>  CONFIG_I8259=y
>  CONFIG_JAZZ_LED=y
>  CONFIG_MC146818RTC=y
> -CONFIG_VT82C686=y
>  CONFIG_ISA_TESTDEV=y
>  CONFIG_EMPTY_SLOT=y
> 

Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>