From: Daniel Borkmann <dborkman@redhat.com>
To: Cong Wang <cwang@twopensource.com>
Cc: David Miller <davem@davemloft.net>,
lw1a2.jing@gmail.com, netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
David L Stevens <david.stevens@oracle.com>
Subject: Re: [PATCH net v4] ipv6: mld: fix add_grhead skb_over_panic for devs with large MTUs
Date: Wed, 05 Nov 2014 23:46:05 +0100 [thread overview]
Message-ID: <545AA8AD.2040807@redhat.com> (raw)
In-Reply-To: <CAHA+R7NKPvhut_K+xgtyJqd=a8Y=dfU80e8C7Jo1qgTdg=2ubg@mail.gmail.com>
On 11/05/2014 11:11 PM, Cong Wang wrote:
> On Wed, Nov 5, 2014 at 11:27 AM, Daniel Borkmann <dborkman@redhat.com> wrote:
>> -static struct sk_buff *mld_newpack(struct inet6_dev *idev, int size)
>> +static struct sk_buff *mld_newpack(struct inet6_dev *idev, unsigned int mtu)
>
> For net-next, you probably want to get rid of the 'mtu' parameter,
> since all callers use dev->mtu. :)
Yeah, feel free. ;) Probably for the longer term it might make sense to
look into ways to refactor and unify some of the more generic portions of
the IGMP/MLD code.
next prev parent reply other threads:[~2014-11-05 22:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 19:27 [PATCH net v4] ipv6: mld: fix add_grhead skb_over_panic for devs with large MTUs Daniel Borkmann
2014-11-05 20:47 ` Eric Dumazet
2014-11-05 21:31 ` Daniel Borkmann
2014-11-05 22:11 ` Cong Wang
2014-11-05 22:46 ` Daniel Borkmann [this message]
2014-11-05 23:32 ` Hannes Frederic Sowa
2014-11-06 3:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545AA8AD.2040807@redhat.com \
--to=dborkman@redhat.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=david.stevens@oracle.com \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=lw1a2.jing@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.