From: Gu Zheng <guz.fnst@cn.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Benjamin LaHaise <bcrl@kvack.org>, <linux-aio@kvack.org>,
<m.koenigshaus@wut.de>, <linux-kernel@vger.kernel.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] aio: fix uncorrent dirty pages accouting when truncating AIO ring buffer
Date: Thu, 6 Nov 2014 09:14:27 +0800 [thread overview]
Message-ID: <545ACB73.3050402@cn.fujitsu.com> (raw)
In-Reply-To: <20141105130018.7750139c497f842bdf6070e4@linux-foundation.org>
Hi Andrew,
On 11/06/2014 05:00 AM, Andrew Morton wrote:
> On Wed, 5 Nov 2014 09:56:20 -0500 Benjamin LaHaise <bcrl@kvack.org> wrote:
>
>> On Wed, Nov 05, 2014 at 05:53:11PM +0800, Gu Zheng wrote:
>>> ping...
>>
>> I need someone a bit more familiar with this area of code to chime in on
>> reviewing this. Andrew, can you provide any feedback on this fix?
>
> That looks like a sensible solution and the changelog is good. A
> couple of suggested modifications:
>
> - Don't use the term "pinned" in the changelog without explaining it
> - it's a terribly ambiguous term. I assume here you mean "pinned by
> elevating the page's refcount"?
Yes.
>
> - Could we have just one wee little code comment, explaining why
> aio_fs_backing_dev_info exists, what function it is serving? Put
> yourself in the position of a reader wondering "why is this here".
> .
Got it.
Thanks for your suggestion. Will update it soon.
Regards,
Gu
>
prev parent reply other threads:[~2014-11-06 1:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1414750042-20832-1-git-send-email-guz.fnst@cn.fujitsu.com>
2014-11-05 9:53 ` [PATCH] aio: fix uncorrent dirty pages accouting when truncating AIO ring buffer Gu Zheng
2014-11-05 14:56 ` Benjamin LaHaise
2014-11-05 14:56 ` Benjamin LaHaise
2014-11-05 21:00 ` Andrew Morton
2014-11-06 1:14 ` Gu Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545ACB73.3050402@cn.fujitsu.com \
--to=guz.fnst@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.koenigshaus@wut.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.