All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joseph Qi <joseph.qi@huawei.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: Remove pointless assignment in ocfs2_init()
Date: Thu, 6 Nov 2014 10:02:18 +0800	[thread overview]
Message-ID: <545AD6AA.8030007@huawei.com> (raw)
In-Reply-To: <1413903774-18825-1-git-send-email-jack@suse.cz>

Does it mean we can ignore the failure of creating debugfs?

On 2014/10/21 23:02, Jan Kara wrote:
> Remove assignment which is never used.
> 
> Coverity-id: 1227009
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
>  fs/ocfs2/super.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> index 93c85bc745e1..e1be0f0ea411 100644
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -1621,10 +1621,8 @@ static int __init ocfs2_init(void)
>  	}
>  
>  	ocfs2_debugfs_root = debugfs_create_dir("ocfs2", NULL);
> -	if (!ocfs2_debugfs_root) {
> -		status = -EFAULT;
> +	if (!ocfs2_debugfs_root)
>  		mlog(ML_ERROR, "Unable to create ocfs2 debugfs root.\n");
> -	}
>  
>  	ocfs2_set_locking_protocol();
>  
> 

  reply	other threads:[~2014-11-06  2:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-21 15:02 [Ocfs2-devel] [PATCH] ocfs2: Remove pointless assignment in ocfs2_init() Jan Kara
2014-11-06  2:02 ` Joseph Qi [this message]
2014-11-06  6:46   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545AD6AA.8030007@huawei.com \
    --to=joseph.qi@huawei.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.