[Ocfs2-devel] [PATCH] ocfs2: Remove pointless assignment in ocfs2_init()

[Ocfs2-devel] [PATCH] ocfs2: Remove pointless assignment in ocfs2_init()

[Jan Kara]

Remove assignment which is never used.

Coverity-id: 1227009
Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/ocfs2/super.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
index 93c85bc745e1..e1be0f0ea411 100644
--- a/fs/ocfs2/super.c
+++ b/fs/ocfs2/super.c
@@ -1621,10 +1621,8 @@ static int __init ocfs2_init(void)
 	}
 
 	ocfs2_debugfs_root = debugfs_create_dir("ocfs2", NULL);
-	if (!ocfs2_debugfs_root) {
-		status = -EFAULT;
+	if (!ocfs2_debugfs_root)
 		mlog(ML_ERROR, "Unable to create ocfs2 debugfs root.\n");
-	}
 
 	ocfs2_set_locking_protocol();
 
-- 
1.8.1.4

[Ocfs2-devel] [PATCH] ocfs2: Remove pointless assignment in ocfs2_init()

[Joseph Qi]

Does it mean we can ignore the failure of creating debugfs?

On 2014/10/21 23:02, Jan Kara wrote:
> Remove assignment which is never used.
> 
> Coverity-id: 1227009
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
>  fs/ocfs2/super.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> index 93c85bc745e1..e1be0f0ea411 100644
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -1621,10 +1621,8 @@ static int __init ocfs2_init(void)
>  	}
>  
>  	ocfs2_debugfs_root = debugfs_create_dir("ocfs2", NULL);
> -	if (!ocfs2_debugfs_root) {
> -		status = -EFAULT;
> +	if (!ocfs2_debugfs_root)
>  		mlog(ML_ERROR, "Unable to create ocfs2 debugfs root.\n");
> -	}
>  
>  	ocfs2_set_locking_protocol();
>  
> 

[Ocfs2-devel] [PATCH] ocfs2: Remove pointless assignment in ocfs2_init()

[Jan Kara]

On Thu 06-11-14 10:02:18, Joseph Qi wrote:
> Does it mean we can ignore the failure of creating debugfs?
  Yes, generally it's the case that debugfs is optional and filesystem can
function without it just fine. OTOH looking more into where
ocfs2_debugfs_root is used, failure to create ocfs2_debugfs_root will lead
to debugfs entries being created in the root directory of debugfs
filesystem which is confusing to say the least. So for simplicity it's
probably better to just bail out with ENOMEM when we fail to create the
root. I'll send an updated patch. Thanks for review!

								Honza
> 
> On 2014/10/21 23:02, Jan Kara wrote:
> > Remove assignment which is never used.
> > 
> > Coverity-id: 1227009
> > Signed-off-by: Jan Kara <jack@suse.cz>
> > ---
> >  fs/ocfs2/super.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> > index 93c85bc745e1..e1be0f0ea411 100644
> > --- a/fs/ocfs2/super.c
> > +++ b/fs/ocfs2/super.c
> > @@ -1621,10 +1621,8 @@ static int __init ocfs2_init(void)
> >  	}
> >  
> >  	ocfs2_debugfs_root = debugfs_create_dir("ocfs2", NULL);
> > -	if (!ocfs2_debugfs_root) {
> > -		status = -EFAULT;
> > +	if (!ocfs2_debugfs_root)
> >  		mlog(ML_ERROR, "Unable to create ocfs2 debugfs root.\n");
> > -	}
> >  
> >  	ocfs2_set_locking_protocol();
> >  
> > 
> 
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR