From: Kishon Vijay Abraham I <kishon@ti.com>
To: Jingoo Han <jg1.han@samsung.com>,
"'Bjorn Helgaas'" <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] PCI: dra7xx: Add dra7xx prefix before add_pcie_port
Date: Thu, 6 Nov 2014 10:36:57 +0530 [thread overview]
Message-ID: <545B01F1.7070009@ti.com> (raw)
In-Reply-To: <001301cff95e$a124f6b0$e36ee410$%han@samsung.com>
On Thursday 06 November 2014 06:41 AM, Jingoo Han wrote:
> The add_pcie_port function is dra7xx-specific. Add exynos prefix
> to avoid collision in global name space.
%s/exynos/dra7xx
After fixing this you can add
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/pci/host/pci-dra7xx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
> index 52b34fe..5b4a644 100644
> --- a/drivers/pci/host/pci-dra7xx.c
> +++ b/drivers/pci/host/pci-dra7xx.c
> @@ -270,8 +270,8 @@ static irqreturn_t dra7xx_pcie_irq_handler(int irq, void *arg)
> return IRQ_HANDLED;
> }
>
> -static int add_pcie_port(struct dra7xx_pcie *dra7xx,
> - struct platform_device *pdev)
> +static int dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
> + struct platform_device *pdev)
> {
> int ret;
> struct pcie_port *pp;
> @@ -398,7 +398,7 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, dra7xx);
>
> - ret = add_pcie_port(dra7xx, pdev);
> + ret = dra7xx_add_pcie_port(dra7xx, pdev);
> if (ret < 0)
> goto err_add_port;
>
>
next prev parent reply other threads:[~2014-11-06 5:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 1:11 [PATCH] PCI: dra7xx: Add dra7xx prefix before add_pcie_port Jingoo Han
2014-11-06 5:06 ` Kishon Vijay Abraham I [this message]
2014-11-06 5:27 ` Jingoo Han
2014-11-06 5:30 ` [PATCH V2] " Jingoo Han
2014-11-13 16:42 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545B01F1.7070009@ti.com \
--to=kishon@ti.com \
--cc=bhelgaas@google.com \
--cc=jg1.han@samsung.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.