From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmKWl-0000Ia-0O for qemu-devel@nongnu.org; Thu, 06 Nov 2014 05:43:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XmKWf-0007Oi-UI for qemu-devel@nongnu.org; Thu, 06 Nov 2014 05:42:54 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:62893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmKWf-0007O1-OG for qemu-devel@nongnu.org; Thu, 06 Nov 2014 05:42:49 -0500 Message-ID: <545B50A5.3040508@imgtec.com> Date: Thu, 6 Nov 2014 10:42:45 +0000 From: Yongbok Kim MIME-Version: 1.0 References: <1415269778-2162-1-git-send-email-leon.alrae@imgtec.com> In-Reply-To: <1415269778-2162-1-git-send-email-leon.alrae@imgtec.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-mips: fix for missing delay slot in BC1EQZ and BC1NEZ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leon Alrae , qemu-devel@nongnu.org Cc: aurelien@aurel32.net On 06/11/2014 10:29, Leon Alrae wrote: > New R6 COP1 conditional branches currently don't have delay slot. Fixing this > by setting MIPS_HFLAG_BDS32 flag which is required for branches having 4-byte > delay slot. > > Signed-off-by: Leon Alrae > --- > target-mips/translate.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target-mips/translate.c b/target-mips/translate.c > index 2117ce8..e83c50a 100644 > --- a/target-mips/translate.c > +++ b/target-mips/translate.c > @@ -8104,6 +8104,7 @@ static void gen_compute_branch1_r6(DisasContext *ctx, uint32_t op, > MIPS_DEBUG("%s: cond %02x target " TARGET_FMT_lx, opn, > ctx->hflags, btarget); > ctx->btarget = btarget; > + ctx->hflags |= MIPS_HFLAG_BDS32; > > out: > tcg_temp_free_i64(t0); Reviewed-by: Yongbok Kim Regards, Yongbok Kim