All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Townsend <martin.townsend@xsilon.com>
To: Jukka Rissanen <jukka.rissanen@linux.intel.com>,
	Martin Townsend <mtownsend1973@gmail.com>
Cc: linux-wpan@vger.kernel.org, linux-bluetooth@vger.kernel.org,
	alex.aring@gmail.com, marcel@holtmann.org
Subject: Re: [PATCH bluetooth-next] 6lowpan: move skb_free from error paths in decompression.
Date: Thu, 06 Nov 2014 10:44:58 +0000	[thread overview]
Message-ID: <545B512A.1070900@xsilon.com> (raw)
In-Reply-To: <1415270051.2918.49.camel@jrissane-mobl.ger.corp.intel.com>

Thanks for testing Jukka,

I'll respin v2 later.
Out of interest, did you have kmemleak on?

- Martin.

On 06/11/14 10:34, Jukka Rissanen wrote:
> Hi Martin,
>
> On ti, 2014-11-04 at 21:36 +0000, Martin Townsend wrote:
>> Currently we ensure that the skb is freed on every error path in IPHC
>> decompression which makes it easy to introduce skb leaks.  By centralising
>> the skb_free into the receive function it makes future decompression routines
>> easier to maintain.  It does come at the expense of ensuring that the skb
>> passed into the decompression routine must not be copied.
> Tested this with real bluetooth hw and no issues were found. Just rebase
> the patch with latest upstream (conflict had a very simple fix) so ack
> with actions to v2.
>
> Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
>
>
> Cheers,
> Jukka
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-11-06 10:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 21:36 [PATCH bluetooth-next] 6lowpan: move skb_free from error paths in decompression Martin Townsend
2014-11-05 21:01 ` Alexander Aring
2014-11-06  8:11   ` Martin Townsend
2014-11-06 10:34 ` Jukka Rissanen
2014-11-06 10:44   ` Martin Townsend [this message]
2014-11-06 10:47     ` Jukka Rissanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545B512A.1070900@xsilon.com \
    --to=martin.townsend@xsilon.com \
    --cc=alex.aring@gmail.com \
    --cc=jukka.rissanen@linux.intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mtownsend1973@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.