From: Ronald Wahl <ronald.wahl@raritan.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linux-wireless@vger.kernel.org>,
Christian Lamparter <chunkeey@googlemail.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH] mac80211: Fix regression that triggers a kernel BUG with CCMP
Date: Thu, 6 Nov 2014 11:47:15 +0100 [thread overview]
Message-ID: <545B51B3.9000901@raritan.com> (raw)
In-Reply-To: <1415268135.1884.1.camel@sipsolutions.net>
On 06.11.2014 11:02, Johannes Berg wrote:
> On Thu, 2014-11-06 at 10:55 +0100, Ronald Wahl wrote:
>> Commit 7ec7c4a9a686c608315739ab6a2b0527a240883c (mac80211: port CCMP to
>> cryptoapi's CCM driver) introduced a regression when decrypting empty
>> packets (data_len == 0). This will lead to backtraces like:
>
> Not good.
>
>> This patch adds an additional length check.
>>
>> Signed-off-by: Ronald Wahl <ronald.wahl@raritan.com>
>
> Please add
>
> Cc: stable@vger.kernel.org
> Fixes: 7ec7c4a9a686 ("mac80211: port CCMP to cryptoapi's CCM driver")
>
>> + if (data_len == 0)
>> + return EINVAL;
>
> error codes should be negative.
Argh. New patch on the way...
thx,
ron
--
Ronald Wahl - ronald.wahl@raritan.com - Phone +49 375271349-0 Fax -99
Raritan Deutschland GmbH, Kornmarkt 7, 08056 Zwickau, Germany
USt-IdNr. DE813094160, Steuer-Nr. 227/117/01749
Amtsgericht Chemnitz HRB 23605
Geschäftsführung: Stuart Hopper, Ralf Ploenes
next prev parent reply other threads:[~2014-11-06 10:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 9:55 [PATCH] mac80211: Fix regression that triggers a kernel BUG with CCMP Ronald Wahl
2014-11-06 10:01 ` Ard Biesheuvel
2014-11-06 10:02 ` Johannes Berg
2014-11-06 10:47 ` Ronald Wahl [this message]
2014-11-06 12:34 ` Arend van Spriel
2014-11-06 12:39 ` Johannes Berg
2014-11-06 13:07 ` Ronald Wahl
2014-11-06 13:14 ` Johannes Berg
2014-11-06 13:50 ` Ronald Wahl
2014-11-06 13:55 ` Ard Biesheuvel
2014-11-06 21:05 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545B51B3.9000901@raritan.com \
--to=ronald.wahl@raritan.com \
--cc=ard.biesheuvel@linaro.org \
--cc=chunkeey@googlemail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.