[Buildroot] [PATCH] uclibc: respect top-level TARGET_CFLAGS

[Gustavo Zacarias <gustavo@zacarias.com.ar>]

On 11/06/2014 08:47 AM, Alexey Brodkin wrote:

> When BR2_TARGET_OPTIMIZATION is used (with some specific compiler flags)
> it's expected that ALL target binaries will be built with specified options.
> 
> Currently uClibc is built with its own set of options.
> This change allows passing additional flags to uclibc build system.
> 
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>

This was rejected before:
https://bugs.busybox.net/show_bug.cgi?id=5294

And i'm back to my original question, what's the specific need for this?
Even for eglibc/glibc we force -O2 for example.
If there's a very valid (like, it breaks!) reason for this we can look
for a way to address it, but as-is i say NAK.
If you look at uClibc's Rules.mak file you'll see there are lots of
OPTIMIZATION/CPU_CFLAGS (and other) conditionals that could be undone by
this and lead to unexpected results.
Regards.