From: Lars-Peter Clausen <lars@metafoo.de>
To: Peter Rosin <peda@lysator.liu.se>, alsa-devel@alsa-project.org
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Peter Rosin <peda@axentia.se>,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier.
Date: Thu, 06 Nov 2014 14:27:26 +0100 [thread overview]
Message-ID: <545B773E.3020103@metafoo.de> (raw)
In-Reply-To: <1415278441-27866-2-git-send-email-peda@lysator.liu.se>
On 11/06/2014 01:54 PM, Peter Rosin wrote:
[...]
> +#define TFA9879_REG(codec, reg, field, value) \
> + snd_soc_update_bits(codec, TFA9879_ ## reg, \
> + TFA9879_ ## field ## _MASK, \
> + (value) << TFA9879_ ## field ## _SHIFT)
> +
I'm not sure I like this macro. Just using snd_soc_update_bits should make
it easier to review the patch since people understand its sematnics.
[...]
> +static int tfa9879_probe(struct snd_soc_codec *codec)
> +{
> + struct tfa9879_priv *tfa9879 = snd_soc_codec_get_drvdata(codec);
> +
> + codec->control_data = tfa9879->regmap;
This is no longer necessary and won't even build with the latest ASoC tree.
> +
> + return 0;
> +}
> +
[...]
> +static struct snd_soc_dai_ops tfa9879_dai_ops = {
const
> + .prepare = tfa9879_prepare,
> + .hw_params = tfa9879_hw_params,
> + .shutdown = tfa9879_shutdown,
> + .digital_mute = tfa9879_digital_mute,
> + .set_fmt = tfa9879_set_fmt,
> +};
[...]
next prev parent reply other threads:[~2014-11-06 13:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 12:53 NXP Semiconductors TFA9879 Amplifier Driver Peter Rosin
2014-11-06 12:53 ` Peter Rosin
2014-11-06 12:54 ` [PATCH 1/2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier Peter Rosin
2014-11-06 13:27 ` Lars-Peter Clausen [this message]
2014-11-06 13:37 ` Mark Brown
2014-11-06 14:37 ` Peter Rosin
2014-11-06 16:02 ` Mark Brown
2014-11-06 16:02 ` Mark Brown
2014-11-06 16:39 ` [v2] NXP Semiconductors TFA9879 Amplifier Driver Peter Rosin
2014-11-06 16:39 ` Peter Rosin
2014-11-06 16:39 ` [PATCH v2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier Peter Rosin
2014-11-07 11:17 ` Mark Brown
2014-11-08 13:40 ` NXP Semiconductors TFA9879 Amplifier Driver Peter Rosin
2014-11-08 13:40 ` Peter Rosin
2014-11-08 13:40 ` [PATCH v3] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier Peter Rosin
2014-11-09 9:46 ` Mark Brown
2014-11-06 12:54 ` [PATCH 2/2] ASoC: tfa9879: Add bass and treble gain/freq controls Peter Rosin
2014-11-06 12:54 ` Peter Rosin
2014-11-06 13:17 ` [alsa-devel] " Lars-Peter Clausen
2014-11-06 13:40 ` Mark Brown
2014-11-06 13:15 ` NXP Semiconductors TFA9879 Amplifier Driver Frans Klaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545B773E.3020103@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=peda@lysator.liu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.