From: Fabien Proriol <Fabien.Proriol@jdsu.com>
To: Jonathan Cameron <jic23@kernel.org>,
Michal Simek <michal.simek@xilinx.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: [PATCH] 0001-xilinx-xadc-core-Fix-voltage-offset.patch
Date: Thu, 6 Nov 2014 15:33:45 +0000 [thread overview]
Message-ID: <545B9479.5030700@jdsu.com> (raw)
From 3f57e39e3c69476513c00cd5ec45703f58334972 Mon Sep 17 00:00:00 2001
From: Fabien Proriol <fabien.proriol@jdsu.com>
Date: Tue, 4 Nov 2014 17:05:59 +0100
Subject: [PATCH] xilinx-xadc-core: Fix voltage offset
When xilinx-xadc is used with hwmon driver to read voltage, offset used
for temperature is always apply.
This patch change the return for IIO_CHAN_INFO_OFFSET to -EINVAL except
for temperature to avoid offset.
Signed-off-by: Fabien Proriol <fabien.proriol@jdsu.com>
---
drivers/iio/adc/xilinx-xadc-core.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/adc/xilinx-xadc-core.c
b/drivers/iio/adc/xilinx-xadc-core.c
index 41d3a5e..6064d26 100644
--- a/drivers/iio/adc/xilinx-xadc-core.c
+++ b/drivers/iio/adc/xilinx-xadc-core.c
@@ -877,9 +877,14 @@ static int xadc_read_raw(struct iio_dev *indio_dev,
return -EINVAL;
}
case IIO_CHAN_INFO_OFFSET:
- /* Only the temperature channel has an offset */
- *val = -((273150 << 12) / 503975);
- return IIO_VAL_INT;
+ switch (chan->type) {
+ case IIO_TEMP:
+ /* Only the temperature channel has an offset */
+ *val = -((273150 << 12) / 503975);
+ return IIO_VAL_INT;
+ default:
+ return -EINVAL;
+ }
case IIO_CHAN_INFO_SAMP_FREQ:
ret = xadc_read_adc_reg(xadc, XADC_REG_CONF2, &val16);
if (ret)
--
2.0.4
next reply other threads:[~2014-11-06 15:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 15:33 Fabien Proriol [this message]
2014-11-06 15:44 ` [PATCH] 0001-xilinx-xadc-core-Fix-voltage-offset.patch Lars-Peter Clausen
2014-11-06 16:18 ` Fabien Proriol
2014-11-06 16:25 ` Lars-Peter Clausen
2014-11-16 20:29 ` Jonathan Cameron
2014-11-16 20:35 ` Lars-Peter Clausen
[not found] ` <545BA802.5090206@jdsu.com>
[not found] ` <54690AE5.4050900@metafoo.de>
2014-11-17 8:53 ` Fabien Proriol
2014-11-17 8:55 ` Lars-Peter Clausen
2014-11-22 11:44 ` Jonathan Cameron
2014-12-05 16:12 ` Fabien Proriol
2015-01-01 12:50 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545B9479.5030700@jdsu.com \
--to=fabien.proriol@jdsu.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.