From: Lars-Peter Clausen <lars@metafoo.de>
To: Fabien Proriol <Fabien.Proriol@jdsu.com>,
Jonathan Cameron <jic23@kernel.org>,
Michal Simek <michal.simek@xilinx.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] 0001-xilinx-xadc-core-Fix-voltage-offset.patch
Date: Thu, 06 Nov 2014 16:44:45 +0100 [thread overview]
Message-ID: <545B976D.4080303@metafoo.de> (raw)
In-Reply-To: <545B9479.5030700@jdsu.com>
On 11/06/2014 04:33 PM, Fabien Proriol wrote:
> From 3f57e39e3c69476513c00cd5ec45703f58334972 Mon Sep 17 00:00:00 2001
> From: Fabien Proriol <fabien.proriol@jdsu.com>
> Date: Tue, 4 Nov 2014 17:05:59 +0100
> Subject: [PATCH] xilinx-xadc-core: Fix voltage offset
>
> When xilinx-xadc is used with hwmon driver to read voltage, offset used
> for temperature is always apply.
> This patch change the return for IIO_CHAN_INFO_OFFSET to -EINVAL except
> for temperature to avoid offset.
I think we should rather fix iio_channel_read() to check if the channel
supports the property that we try to read. Other drivers are likely to
suffer from the same issue and fixing it in a central place fixes them all.
- Lars
next prev parent reply other threads:[~2014-11-06 15:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 15:33 [PATCH] 0001-xilinx-xadc-core-Fix-voltage-offset.patch Fabien Proriol
2014-11-06 15:44 ` Lars-Peter Clausen [this message]
2014-11-06 16:18 ` Fabien Proriol
2014-11-06 16:25 ` Lars-Peter Clausen
2014-11-16 20:29 ` Jonathan Cameron
2014-11-16 20:35 ` Lars-Peter Clausen
[not found] ` <545BA802.5090206@jdsu.com>
[not found] ` <54690AE5.4050900@metafoo.de>
2014-11-17 8:53 ` Fabien Proriol
2014-11-17 8:55 ` Lars-Peter Clausen
2014-11-22 11:44 ` Jonathan Cameron
2014-12-05 16:12 ` Fabien Proriol
2015-01-01 12:50 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545B976D.4080303@metafoo.de \
--to=lars@metafoo.de \
--cc=Fabien.Proriol@jdsu.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.