From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heinrich Schuchardt Subject: Re: [PATCH 3/3] fsnotify: Remove destroy_list from fsnotify_mark Date: Thu, 06 Nov 2014 22:17:32 +0100 Message-ID: <545BE56C.5080502@gmx.de> References: <1415279020-9175-1-git-send-email-jack@suse.cz> <1415279020-9175-4-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, Eric Paris To: Jan Kara , Andrew Morton Return-path: Received: from mout.gmx.net ([212.227.15.19]:59450 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751167AbaKFVSY (ORCPT ); Thu, 6 Nov 2014 16:18:24 -0500 In-Reply-To: <1415279020-9175-4-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 06.11.2014 14:03, Jan Kara wrote: > destroy_list is used to track marks which still need waiting for srcu > period end before they can be freed. However by the time mark is added > to destroy_list it isn't in group's list of marks anymore and thus we > can reuse fsnotify_mark->g_list for queueing into destroy_list. This > saves two pointers for each fsnotify_mark. With your patch the information how g_list is used is only provided in the commit message (same is true for obj_list in PATCH 2/3). Please, provide comments for the fields of structure fsnotify_mark in include/linux/fsnotify_backend.h indicating how these fields are used. Especially if a field is reused for different purposes, as you now suggest for g_list (and obj_list), this information is indispensable. Best regards Heinrich Schuchardt