All of lore.kernel.org
 help / color / mirror / Atom feed
From: Barto <mister.freeman@laposte.net>
To: "Liu, Chuansheng" <chuansheng.liu@intel.com>
Cc: "aaron.lu"@intel.com, tj@kernel.org, rjw@rjwysocki.net,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: new test
Date: Thu, 06 Nov 2014 23:40:07 +0100	[thread overview]
Message-ID: <545BF8C7.7070206@laposte.net> (raw)
In-Reply-To: <27240C0AC20F114CBF8149A2696CBE4A01EB8625@SHSMSX101.ccr.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1459 bytes --]

Hello Liu Chuansheng,

I have good news, your patch based on /drivers/pci/quirks.c works very
well,

I have no problems after a standby mode, my JMB363/368 SATA/IDE JMicron
Pcie works without problems


Le 06/11/2014 15:33, Liu, Chuansheng a écrit :
> Thanks Barto. 
> 
> Could you try below patch? I made the change in file quirks.c.
>   
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> 
> index 90acb32..b40485f 100644
> 
> --- a/drivers/pci/quirks.c
> 
> +++ b/drivers/pci/quirks.c
> 
> @@ -29,6 +29,21 @@
> 
> #include "pci.h"
> 
>  /*
> 
> + * For JMicron chips, we need to disable the async_suspend method,
> otherwise
> 
> + * they will hit the power-on issue when doing device resume, add one quick
> 
> + * solution to disable the async_suspend method.
> 
> + */
> 
> +static void pci_async_suspend_fixup(struct pci_dev *pdev)
> 
> +{
> 
> +        /* 
> 
> +         * disabling the async_suspend method for JMicron chips to
> 
> +         * avoid device resuming issue.
> 
> +         */
> 
> +        device_disable_async_suspend(&pdev->dev);
> 
> +}
> 
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_JMICRON, PCI_ANY_ID,
> pci_async_suspend_fixup);
> 
> +
> 
> +/*
> 
>   * Decoding should be disabled for a PCI device during BAR sizing to avoid
> 
>   * conflict. But doing so may cause problems on host bridge and perhaps
> other
> 
>   * key system devices. For devices that need to have mmio decoding
> always-on,
> 
>  
> 
>  
> 

[-- Attachment #2: jmicron2.patch --]
[-- Type: text/x-patch, Size: 967 bytes --]

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 90acb32..b40485f 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -29,6 +29,21 @@
#include "pci.h"
 /*
+ * For JMicron chips, we need to disable the async_suspend method, otherwise
+ * they will hit the power-on issue when doing device resume, add one quick
+ * solution to disable the async_suspend method.
+ */
+static void pci_async_suspend_fixup(struct pci_dev *pdev)
+{
+        /*
+         * disabling the async_suspend method for JMicron chips to
+         * avoid device resuming issue.
+         */
+        device_disable_async_suspend(&pdev->dev);
+}
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_JMICRON, PCI_ANY_ID, pci_async_suspend_fixup);
+
+/*
  * Decoding should be disabled for a PCI device during BAR sizing to avoid
  * conflict. But doing so may cause problems on host bridge and perhaps other
  * key system devices. For devices that need to have mmio decoding always-on,

           reply	other threads:[~2014-11-06 22:40 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <27240C0AC20F114CBF8149A2696CBE4A01EB8625@SHSMSX101.ccr.corp.intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545BF8C7.7070206@laposte.net \
    --to=mister.freeman@laposte.net \
    --cc=aaron.lu@intel.com \
    --cc=chuansheng.liu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.