From: Jeff Wang <jeffrey.wang@ll.mit.edu>
To: <yocto@yoctoproject.org>
Subject: Test in do_patch() fails for annotated tags
Date: Thu, 6 Nov 2014 18:12:39 -0500 [thread overview]
Message-ID: <545C0067.1080506@ll.mit.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 602 bytes --]
Commit 92c1ece6c347030d48995a36f4c67861356e59d3 causes the test in
do_patch() in kernel-yocto.bbclass to fail if ${machine_srcrev} is an
annotated tag. The check is meant to ensure that ${machine_srcrev} is an
ancestor of HEAD, but if ${machine_srcrev} is a tag, then "$(git
rev-parse --verify ${machine_srcrev})" evaluates to the SHA of the tag
instead of what it's pointing to.
Replacing "$(git rev-parse --verify ${machine_srcrev})" with "$(git
rev-parse --verify ${machine_srcrev}~0)" seems to fix the problem. See
http://stackoverflow.com/a/1863712/1454667
--
Jeff Wang
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 3145 bytes --]
next reply other threads:[~2014-11-07 0:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 23:12 Jeff Wang [this message]
2014-11-07 16:44 ` Test in do_patch() fails for annotated tags Bruce Ashfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545C0067.1080506@ll.mit.edu \
--to=jeffrey.wang@ll.mit.edu \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.