From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH 0/2] lib/librte_vhost: coding style fixes Date: Fri, 07 Nov 2014 12:16:53 +0900 Message-ID: <545C39A5.50209@igel.co.jp> References: <1415249165-24634-1-git-send-email-huawei.xie@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit To: dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1415249165-24634-1-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Xie, Do you have a plan to fix coding style of 'librte_vhost/vhost-net-cdev.h'? Especially, PRINT_PACKET macro. Thanks, Tetsuya (2014/11/06 13:46), Huawei Xie wrote: > This patchset fixes serious coding style issues in vhost library. > > Huawei Xie (2): > fix alignment, lengthy lines, misordered type and other style issues > printk -> pr_debug > > lib/librte_vhost/eventfd_link/eventfd_link.c | 244 ++++++++++----------- > lib/librte_vhost/eventfd_link/eventfd_link.h | 127 ++++++----- > lib/librte_vhost/rte_virtio_net.h | 3 +- > lib/librte_vhost/vhost-net-cdev.c | 187 +++++++++------- > lib/librte_vhost/vhost_rxtx.c | 13 +- > lib/librte_vhost/virtio-net.c | 317 +++++++++++++++++---------- > 6 files changed, 494 insertions(+), 397 deletions(-) >