From: Bart Van Assche <bvanassche@acm.org>
To: Hannes Reinecke <hare@suse.de>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH 22/30] multipath: Implement 'property' blacklist
Date: Fri, 07 Nov 2014 10:04:40 +0100 [thread overview]
Message-ID: <545C8B28.7010006@acm.org> (raw)
In-Reply-To: <53F64913.3060801@suse.de>
On 08/21/14 21:31, Hannes Reinecke wrote:
> On 08/21/2014 06:37 PM, Bart Van Assche wrote:
>> Hannes Reinecke <hare <at> suse.de> writes:
>>> Multipath can only handle device properly which support the VPD
>>> page 0x83. Originally this was ensured by 'scsi_id', which would
>>> not present an ID_SERIAL value in these cases.
>>> With the move to udev 'ID_SERIAL' is now always present, so
>>> multipath would try to attach to _all_ SCSI devices.
>>> This patch implements an 'property' blacklist, which allows to
>>> blacklist a device based on the existence of udev properties.
>>> Any device not providing the udev property from the whitelist
>>> will be ignored.
>>> The default whitelist is set to '(ID_WWN|ID_SCSI_VPD)'.
>>>
>>> [ ... ]
>>
>> (replying to an e-mail of one year ago)
>>
>> Hello Hannes,
>>
>> I have a question about this patch. Which software component should
>> set the
>> ID_SCSI_VPD parameter ? Is it udev, now integrated in systemd ? I'm
>> asking
>> this because I haven't found any patch in the udev nor in the systemd
>> repositories that sets the ID_SCSI_VPD parameter. Does this mean that
>> another parameter should be used to restore support for SCSI devices that
>> support the VPD page 0x83 but do not report a WWN in that page ? Or does
>> this mean that systemd should be modified such that it sets the
>> ID_SCSI_VPD parameter ?
>
> That's actually simple typo. ID_SCSI_VPD was generated by one of the
> earlier instances of the sg3_utils udev rules.
> It should read 'SCSI_IDENT_LUN', as this is what the current udev rules
> from sg3_utils generate.
> I have a patch queued in my sles12 patchset; but so far haven't found
> time to clean them up and send upstream.
> Will be doing so once sles12 is done...
(replying to an e-mail of two months ago)
Hello Hannes,
Have you already been able to free up some time to revisit what has been
discussed above ?
Thanks,
Bart.
next prev parent reply other threads:[~2014-11-07 9:04 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 7:12 [PATCH 00/30] SLES resync, second try Hannes Reinecke
2013-07-16 7:12 ` [PATCH 01/30] multipath: bind lifetime of udev context to main thread Hannes Reinecke
2013-07-16 7:12 ` [PATCH 02/30] Document 'infinity' as possible value for dev_loss_tmo Hannes Reinecke
2013-07-16 7:12 ` [PATCH 03/30] alua: Do not add preferred path priority for active/optimized Hannes Reinecke
2013-07-16 7:12 ` [PATCH 04/30] multipath: Increase dev_loss_tmo prior to fast_io_fail Hannes Reinecke
2013-07-19 21:17 ` Benjamin Marzinski
2013-07-22 7:19 ` Hannes Reinecke
2013-07-16 7:12 ` [PATCH 05/30] libmultipath: return PATH_DOWN for quiesced paths Hannes Reinecke
2013-07-16 7:12 ` [PATCH 06/30] libmultipath: Implement PATH_TIMEOUT Hannes Reinecke
2013-07-16 7:12 ` [PATCH 07/30] Deprecate pg_timeout Hannes Reinecke
2013-07-16 7:12 ` [PATCH 08/30] kpartx: create correct symlinks for PATH_FAILED events Hannes Reinecke
2013-07-16 7:13 ` [PATCH 09/30] multipath: Deprecate 'getuid' configuration variable Hannes Reinecke
2013-07-16 7:13 ` [PATCH 10/30] kpartx: support disk with non-512B sectors Hannes Reinecke
2013-07-16 7:13 ` [PATCH 11/30] multipath: Add 'Datacore Virtual Disk' to internal hardware table Hannes Reinecke
2013-07-16 7:13 ` [PATCH 12/30] Minor fixes for priority handling Hannes Reinecke
2013-07-16 7:13 ` [PATCH 13/30] Check return value from pathinfo() Hannes Reinecke
2013-07-16 7:13 ` [PATCH 14/30] Read directly from sysfs when checking the device size Hannes Reinecke
2013-07-16 7:13 ` [PATCH 15/30] multipath.conf.annotated: Document rr_min_io_rq Hannes Reinecke
2013-07-16 7:13 ` [PATCH 16/30] Correctly print out 'max' for max_fds Hannes Reinecke
2013-07-16 7:13 ` [PATCH 17/30] Correctly set max_fds in case of failure Hannes Reinecke
2013-07-16 7:13 ` [PATCH 18/30] Update multipath.conf.defaults Hannes Reinecke
2013-07-16 7:13 ` [PATCH 19/30] Correctly set pgfailback Hannes Reinecke
2013-07-16 7:13 ` [PATCH 20/30] multipath.conf.5: clarify 'no_path_retry' default setting Hannes Reinecke
2013-07-16 7:13 ` [PATCH 21/30] multipath.conf.annotated: remove 'udev_dir' Hannes Reinecke
2013-07-16 7:13 ` [PATCH 22/30] multipath: Implement 'property' blacklist Hannes Reinecke
2014-08-21 16:37 ` Bart Van Assche
2014-08-21 19:31 ` Hannes Reinecke
2014-11-07 9:04 ` Bart Van Assche [this message]
2014-11-07 9:09 ` Hannes Reinecke
2014-11-19 5:33 ` Benjamin Marzinski
2013-07-16 7:13 ` [PATCH 23/30] Do not print error when rport is blocked Hannes Reinecke
2013-07-16 7:13 ` [PATCH 24/30] multipath: reference the udev context when starting event queue Hannes Reinecke
2013-07-16 7:13 ` [PATCH 25/30] multipathd: valgrind fixes Hannes Reinecke
2013-07-16 7:13 ` [PATCH 26/30] multipathd: increase stacksize for uevent listener Hannes Reinecke
2013-07-16 7:13 ` [PATCH 27/30] Specify checker_timeout in seconds Hannes Reinecke
2013-07-16 7:13 ` [PATCH 28/30] multipath: fix setting of fast_io_fail_tmo Hannes Reinecke
2013-07-16 7:13 ` [PATCH 29/30] multipath: reset queue_if_no_path if flush failed Hannes Reinecke
2013-07-16 7:13 ` [PATCH 30/30] libmultipath: read path state directly from sysfs Hannes Reinecke
2013-07-16 20:21 ` [PATCH 00/30] SLES resync, second try Christophe Varoqui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545C8B28.7010006@acm.org \
--to=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.