diff for duplicates of <545C9FF0.7010802@arm.com> diff --git a/a/content_digest b/N1/content_digest index 9d97080..56a2e97 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,23 @@ + "ref\01415320848-13813-1-git-send-email-m.smarduch@samsung.com\0" "ref\01415320848-13813-8-git-send-email-m.smarduch@samsung.com\0" "From\0Marc Zyngier <marc.zyngier@arm.com>\0" "Subject\0Re: [PATCH v13 7/7] arm: KVM: ARMv7 dirty page logging 2nd stage page fault\0" "Date\0Fri, 07 Nov 2014 10:33:20 +0000\0" - "To\0kvm-ia64@vger.kernel.org\0" + "To\0Mario Smarduch <m.smarduch@samsung.com>\0" + "Cc\0pbonzini@redhat.com <pbonzini@redhat.com>" + james.hogan@imgtec.com <james.hogan@imgtec.com> + christoffer.dall@linaro.org <christoffer.dall@linaro.org> + agraf@suse.de <agraf@suse.de> + cornelia.huck@de.ibm.com <cornelia.huck@de.ibm.com> + borntraeger@de.ibm.com <borntraeger@de.ibm.com> + Catalin Marinas <Catalin.Marinas@arm.com> + kvmarm@lists.cs.columbia.edu <kvmarm@lists.cs.columbia.edu> + kvm@vger.kernel.org <kvm@vger.kernel.org> + kvm-ppc@vger.kernel.org <kvm-ppc@vger.kernel.org> + kvm-ia64@vger.kernel.org <kvm-ia64@vger.kernel.org> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + Steve Capper <Steve.Capper@arm.com> + " peter.maydell@linaro.org <peter.maydell@linaro.org>\0" "\00:1\0" "b\0" "On 07/11/14 00:40, Mario Smarduch wrote:\n" @@ -150,4 +165,4 @@ "-- \n" Jazz is not dead. It just smells funny... -24281b7b7720b0abb718a0174955f392b7210bcfe37e2cfa338ac345f472f611 +5f9d55e257d28435c1f4e96e1c4544d3fae2dd9d0623a4bec77e71d1cec1aac6
diff --git a/a/1.txt b/N2/1.txt index 18ab587..2824c06 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -3,7 +3,7 @@ On 07/11/14 00:40, Mario Smarduch wrote: > it disables faulting in huge pages, and dissolves huge pages to page tables. > In case migration is canceled huge pages are used again. > -> Reviewed-by: Christoffer Dall <christoffer.dall at linaro.org> +> Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org> > Signed-off-by: Mario Smarduch <m.smarduch@samsung.com> > --- > arch/arm/kvm/mmu.c | 47 ++++++++++++++++++++++++++++++++++++++++------- @@ -84,7 +84,7 @@ comment would be very welcome. > + bool logging_active = kvm_get_logging_state(memslot); > > write_fault = kvm_is_write_fault(kvm_vcpu_get_hsr(vcpu)); -> if (fault_status = FSC_PERM && !write_fault) { +> if (fault_status == FSC_PERM && !write_fault) { > @@ -920,7 +943,7 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > /* Let's check if we will get back a huge page backed by hugetlbfs */ > down_read(¤t->mm->mmap_sem); @@ -107,8 +107,8 @@ comment would be very welcome. > } > coherent_cache_guest_page(vcpu, hva, PAGE_SIZE); > ret = stage2_set_pte(kvm, memcache, fault_ipa, &new_pte, -> - mem_type = PAGE_S2_DEVICE); -> + mem_type = PAGE_S2_DEVICE, +> - mem_type == PAGE_S2_DEVICE); +> + mem_type == PAGE_S2_DEVICE, > + logging_active); > } > @@ -124,7 +124,7 @@ comment would be very welcome. > > - stage2_set_pte(kvm, NULL, gpa, pte, false); > + /* -> + * We can always call stage2_set_pte with logging_active = false, +> + * We can always call stage2_set_pte with logging_active == false, > + * because MMU notifiers will have unmapped a huge PMD before calling > + * ->change_pte() (which in turn calls kvm_set_spte_hva()) and therefore > + * stage2_set_pte() never needs to clear out a huge PMD through this diff --git a/a/content_digest b/N2/content_digest index 9d97080..5049d51 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,8 +1,9 @@ + "ref\01415320848-13813-1-git-send-email-m.smarduch@samsung.com\0" "ref\01415320848-13813-8-git-send-email-m.smarduch@samsung.com\0" - "From\0Marc Zyngier <marc.zyngier@arm.com>\0" - "Subject\0Re: [PATCH v13 7/7] arm: KVM: ARMv7 dirty page logging 2nd stage page fault\0" + "From\0marc.zyngier@arm.com (Marc Zyngier)\0" + "Subject\0[PATCH v13 7/7] arm: KVM: ARMv7 dirty page logging 2nd stage page fault\0" "Date\0Fri, 07 Nov 2014 10:33:20 +0000\0" - "To\0kvm-ia64@vger.kernel.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On 07/11/14 00:40, Mario Smarduch wrote:\n" @@ -10,7 +11,7 @@ "> it disables faulting in huge pages, and dissolves huge pages to page tables.\n" "> In case migration is canceled huge pages are used again.\n" "> \n" - "> Reviewed-by: Christoffer Dall <christoffer.dall at linaro.org>\n" + "> Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>\n" "> Signed-off-by: Mario Smarduch <m.smarduch@samsung.com>\n" "> ---\n" "> arch/arm/kvm/mmu.c | 47 ++++++++++++++++++++++++++++++++++++++++-------\n" @@ -91,7 +92,7 @@ "> +\tbool logging_active = kvm_get_logging_state(memslot);\n" "> \n" "> \twrite_fault = kvm_is_write_fault(kvm_vcpu_get_hsr(vcpu));\n" - "> \tif (fault_status = FSC_PERM && !write_fault) {\n" + "> \tif (fault_status == FSC_PERM && !write_fault) {\n" "> @@ -920,7 +943,7 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa,\n" "> \t/* Let's check if we will get back a huge page backed by hugetlbfs */\n" "> \tdown_read(¤t->mm->mmap_sem);\n" @@ -114,8 +115,8 @@ "> \t\t}\n" "> \t\tcoherent_cache_guest_page(vcpu, hva, PAGE_SIZE);\n" "> \t\tret = stage2_set_pte(kvm, memcache, fault_ipa, &new_pte,\n" - "> -\t\t\t\t mem_type = PAGE_S2_DEVICE);\n" - "> +\t\t\t\t\tmem_type = PAGE_S2_DEVICE,\n" + "> -\t\t\t\t mem_type == PAGE_S2_DEVICE);\n" + "> +\t\t\t\t\tmem_type == PAGE_S2_DEVICE,\n" "> +\t\t\t\t\tlogging_active);\n" "> \t}\n" "> \n" @@ -131,7 +132,7 @@ "> \n" "> -\tstage2_set_pte(kvm, NULL, gpa, pte, false);\n" "> +\t/*\n" - "> +\t * We can always call stage2_set_pte with logging_active = false,\n" + "> +\t * We can always call stage2_set_pte with logging_active == false,\n" "> +\t * because MMU notifiers will have unmapped a huge PMD before calling\n" "> +\t * ->change_pte() (which in turn calls kvm_set_spte_hva()) and therefore\n" "> +\t * stage2_set_pte() never needs to clear out a huge PMD through this\n" @@ -150,4 +151,4 @@ "-- \n" Jazz is not dead. It just smells funny... -24281b7b7720b0abb718a0174955f392b7210bcfe37e2cfa338ac345f472f611 +e6f421233a6e3925c468a40bdf8417eb7b5f841a525a078a9e8dcb99a19e922f
diff --git a/a/1.txt b/N3/1.txt index 18ab587..32a3d41 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -84,7 +84,7 @@ comment would be very welcome. > + bool logging_active = kvm_get_logging_state(memslot); > > write_fault = kvm_is_write_fault(kvm_vcpu_get_hsr(vcpu)); -> if (fault_status = FSC_PERM && !write_fault) { +> if (fault_status == FSC_PERM && !write_fault) { > @@ -920,7 +943,7 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > /* Let's check if we will get back a huge page backed by hugetlbfs */ > down_read(¤t->mm->mmap_sem); @@ -107,8 +107,8 @@ comment would be very welcome. > } > coherent_cache_guest_page(vcpu, hva, PAGE_SIZE); > ret = stage2_set_pte(kvm, memcache, fault_ipa, &new_pte, -> - mem_type = PAGE_S2_DEVICE); -> + mem_type = PAGE_S2_DEVICE, +> - mem_type == PAGE_S2_DEVICE); +> + mem_type == PAGE_S2_DEVICE, > + logging_active); > } > @@ -124,7 +124,7 @@ comment would be very welcome. > > - stage2_set_pte(kvm, NULL, gpa, pte, false); > + /* -> + * We can always call stage2_set_pte with logging_active = false, +> + * We can always call stage2_set_pte with logging_active == false, > + * because MMU notifiers will have unmapped a huge PMD before calling > + * ->change_pte() (which in turn calls kvm_set_spte_hva()) and therefore > + * stage2_set_pte() never needs to clear out a huge PMD through this diff --git a/a/content_digest b/N3/content_digest index 9d97080..c2eae77 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -1,8 +1,23 @@ + "ref\01415320848-13813-1-git-send-email-m.smarduch@samsung.com\0" "ref\01415320848-13813-8-git-send-email-m.smarduch@samsung.com\0" "From\0Marc Zyngier <marc.zyngier@arm.com>\0" "Subject\0Re: [PATCH v13 7/7] arm: KVM: ARMv7 dirty page logging 2nd stage page fault\0" "Date\0Fri, 07 Nov 2014 10:33:20 +0000\0" - "To\0kvm-ia64@vger.kernel.org\0" + "To\0Mario Smarduch <m.smarduch@samsung.com>\0" + "Cc\0pbonzini@redhat.com <pbonzini@redhat.com>" + james.hogan@imgtec.com <james.hogan@imgtec.com> + christoffer.dall@linaro.org <christoffer.dall@linaro.org> + agraf@suse.de <agraf@suse.de> + cornelia.huck@de.ibm.com <cornelia.huck@de.ibm.com> + borntraeger@de.ibm.com <borntraeger@de.ibm.com> + Catalin Marinas <Catalin.Marinas@arm.com> + kvmarm@lists.cs.columbia.edu <kvmarm@lists.cs.columbia.edu> + kvm@vger.kernel.org <kvm@vger.kernel.org> + kvm-ppc@vger.kernel.org <kvm-ppc@vger.kernel.org> + kvm-ia64@vger.kernel.org <kvm-ia64@vger.kernel.org> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + Steve Capper <Steve.Capper@arm.com> + " peter.maydell@linaro.org <peter.maydell@linaro.org>\0" "\00:1\0" "b\0" "On 07/11/14 00:40, Mario Smarduch wrote:\n" @@ -91,7 +106,7 @@ "> +\tbool logging_active = kvm_get_logging_state(memslot);\n" "> \n" "> \twrite_fault = kvm_is_write_fault(kvm_vcpu_get_hsr(vcpu));\n" - "> \tif (fault_status = FSC_PERM && !write_fault) {\n" + "> \tif (fault_status == FSC_PERM && !write_fault) {\n" "> @@ -920,7 +943,7 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa,\n" "> \t/* Let's check if we will get back a huge page backed by hugetlbfs */\n" "> \tdown_read(¤t->mm->mmap_sem);\n" @@ -114,8 +129,8 @@ "> \t\t}\n" "> \t\tcoherent_cache_guest_page(vcpu, hva, PAGE_SIZE);\n" "> \t\tret = stage2_set_pte(kvm, memcache, fault_ipa, &new_pte,\n" - "> -\t\t\t\t mem_type = PAGE_S2_DEVICE);\n" - "> +\t\t\t\t\tmem_type = PAGE_S2_DEVICE,\n" + "> -\t\t\t\t mem_type == PAGE_S2_DEVICE);\n" + "> +\t\t\t\t\tmem_type == PAGE_S2_DEVICE,\n" "> +\t\t\t\t\tlogging_active);\n" "> \t}\n" "> \n" @@ -131,7 +146,7 @@ "> \n" "> -\tstage2_set_pte(kvm, NULL, gpa, pte, false);\n" "> +\t/*\n" - "> +\t * We can always call stage2_set_pte with logging_active = false,\n" + "> +\t * We can always call stage2_set_pte with logging_active == false,\n" "> +\t * because MMU notifiers will have unmapped a huge PMD before calling\n" "> +\t * ->change_pte() (which in turn calls kvm_set_spte_hva()) and therefore\n" "> +\t * stage2_set_pte() never needs to clear out a huge PMD through this\n" @@ -150,4 +165,4 @@ "-- \n" Jazz is not dead. It just smells funny... -24281b7b7720b0abb718a0174955f392b7210bcfe37e2cfa338ac345f472f611 +86c9ddf64ab707b47685596f52143a8c21f0faa85f769246e84af1d0137393e1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.