From: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
To: famz@redhat.com
Cc: Kevin Wolf <kwolf@redhat.com>, Benoit Canet <benoit@irqsave.net>,
Vladimir Sementsov-Ogievskij <etendren@gmail.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, John Snow <jsnow@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Jd <jd_jedi@convirture.com>, Paolo Bonzini <pbonzini@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove
Date: Fri, 7 Nov 2014 15:24:22 +0300 [thread overview]
Message-ID: <545CB9F6.5050906@parallels.com> (raw)
> + if (!name || name[0] == '\0') {
Isn't is better to move "name[0] == '\0'" check to
bdrv_create_dirty_bitmap, near existed name checking?
> + if (granularity < 512 || is_power_of_2(granularity)) {
> + error_setg(errp, "Granularity must be power of 2 "
> + "and greater than 512");
> + return;
> + }
> + } else {
> + granularity = 65536;
> + }
Why not using something like DEFAULT_CLUSTER_SIZE, as in block/qcow2.h ?
--
Best regards,
Vladimir
next reply other threads:[~2014-11-07 12:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 12:24 Vladimir Sementsov-Ogievskiy [this message]
2014-11-19 20:47 ` [Qemu-devel] [PATCH v6 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove John Snow
-- strict thread matches above, loose matches on Subject: below --
2014-10-30 3:22 [Qemu-devel] [PATCH v6 00/10] block: Incremental backup series Fam Zheng
2014-10-30 3:22 ` [Qemu-devel] [PATCH v6 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove Fam Zheng
2014-11-04 9:26 ` Max Reitz
2014-11-07 13:00 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545CB9F6.5050906@parallels.com \
--to=vsementsov@parallels.com \
--cc=armbru@redhat.com \
--cc=benoit@irqsave.net \
--cc=etendren@gmail.com \
--cc=famz@redhat.com \
--cc=jd_jedi@convirture.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.