Re: [PATCH] hpsa: fix potential resource leak

[Tomas Henzl <thenzl@redhat.com>]

My apologies for sending the same mail twice.

Please ignore this one.

--tms


On 11/07/2014 01:27 PM, Tomas Henzl wrote:

> We should free the cfgtable allocated a few lines above.
>
> Signed-off-by: Tomas Henzl <thenzl@redhat.com>
> ---
>  drivers/scsi/hpsa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 1ce2b43608..7d4cef779f 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -5994,7 +5994,7 @@ static int hpsa_kdump_hard_reset_controller(struct pci_dev *pdev)
>  	}
>  	rc = write_driver_ver_to_cfgtable(cfgtable);
>  	if (rc)
> -		goto unmap_vaddr;
> +		goto unmap_cfgtable;
>  
>  	/* If reset via doorbell register is supported, use that.
>  	 * There are two such methods.  Favor the newest method.