Re: [PATCH v2] kvm-s390: Provide guest TOD Clock Get/Set Controls

[Alexander Graf <agraf@suse.de>]

On 07.11.14 16:10, Christian Borntraeger wrote:
> Am 07.11.2014 um 16:06 schrieb Paolo Bonzini:
>>
>>
>> On 07/11/2014 15:55, Jason J. Herne wrote:
>>> From: "Jason J. Herne" <jjherne@linux.vnet.ibm.com>
>>>
>>> Provide KVM_REG_S390_TOD and KVM_REG_S390_TOD_HIGH registers on s390 for
>>> managing guest Time Of Day clock value.
>>>
>>> KVM_REG_S390_TOD_HIGH is presently always set to 0. In the future it will
>>> contain a high order expansion of the tod clock value after it overflows
>>> the 64-bits of KVM_REG_S390_TOD.
>>>
>>> Signed-off-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
>>> ---
>>>  arch/s390/include/uapi/asm/kvm.h |  2 ++
>>>  arch/s390/kvm/kvm-s390.c         | 63 ++++++++++++++++++++++++++++++++++++++++
>>>  2 files changed, 65 insertions(+)
>>>
>>> diff --git a/arch/s390/include/uapi/asm/kvm.h b/arch/s390/include/uapi/asm/kvm.h
>>> index 48eda3a..5578832 100644
>>> --- a/arch/s390/include/uapi/asm/kvm.h
>>> +++ b/arch/s390/include/uapi/asm/kvm.h
>>> @@ -138,4 +138,6 @@ struct kvm_sync_regs {
>>>  #define KVM_REG_S390_PFSELECT	(KVM_REG_S390 | KVM_REG_SIZE_U64 | 0x7)
>>>  #define KVM_REG_S390_PP		(KVM_REG_S390 | KVM_REG_SIZE_U64 | 0x8)
>>>  #define KVM_REG_S390_GBEA	(KVM_REG_S390 | KVM_REG_SIZE_U64 | 0x9)
>>> +#define KVM_REG_S390_TOD	(KVM_REG_S390 | KVM_REG_SIZE_U64 | 0xA)
>>> +#define KVM_REG_S390_TOD_HIGH	(KVM_REG_S390 | KVM_REG_SIZE_U8 | 0xB)
>>>  #endif
>>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>>> index 55aade4..17e3d61 100644
>>> --- a/arch/s390/kvm/kvm-s390.c
>>> +++ b/arch/s390/kvm/kvm-s390.c
>>> @@ -31,6 +31,7 @@
>>>  #include <asm/switch_to.h>
>>>  #include <asm/facility.h>
>>>  #include <asm/sclp.h>
>>> +#include<asm/timex.h>
> 
> Will apply with a small whitespace fix

Reviewed-by: Alexander Graf <agraf@suse.de>


Alex