From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v5 3/5] regulator: of: Add regulator desc param to of_get_regulator_init_data() Date: Fri, 07 Nov 2014 16:49:49 +0100 Message-ID: <545CEA1D.2020109@collabora.co.uk> References: <1415365205-27630-1-git-send-email-javier.martinez@collabora.co.uk> <1415365205-27630-4-git-send-email-javier.martinez@collabora.co.uk> <20141107150743.GR8509@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141107150743.GR8509-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: Kukjin Kim , Chanwoo Choi , Olof Johansson , Chris Zhong , Krzysztof Kozlowski , Abhilash Kesavan , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-samsung-soc@vger.kernel.org Hello Mark, On 11/07/2014 04:07 PM, Mark Brown wrote: > > This is using the regulator descriptor before it is initialized which > doesn't seem ideal... > You are right, even if most of them are not used currently, that may change in the future so is safer to use it after all fields have been initialized. I'll double check all drivers to be sure that's the case. > > This is just adding the include to get the declaration of regulator_desc > as far as I can see, add a forward declaration of it instead. > Perfect, I didn't know what you would prefer. I'll change it in the next version. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752080AbaKGPt5 (ORCPT ); Fri, 7 Nov 2014 10:49:57 -0500 Received: from bhuna.collabora.co.uk ([93.93.135.160]:44439 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797AbaKGPt4 (ORCPT ); Fri, 7 Nov 2014 10:49:56 -0500 Message-ID: <545CEA1D.2020109@collabora.co.uk> Date: Fri, 07 Nov 2014 16:49:49 +0100 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.0 MIME-Version: 1.0 To: Mark Brown CC: Kukjin Kim , Chanwoo Choi , Olof Johansson , Chris Zhong , Krzysztof Kozlowski , Abhilash Kesavan , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 3/5] regulator: of: Add regulator desc param to of_get_regulator_init_data() References: <1415365205-27630-1-git-send-email-javier.martinez@collabora.co.uk> <1415365205-27630-4-git-send-email-javier.martinez@collabora.co.uk> <20141107150743.GR8509@sirena.org.uk> In-Reply-To: <20141107150743.GR8509@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Mark, On 11/07/2014 04:07 PM, Mark Brown wrote: > > This is using the regulator descriptor before it is initialized which > doesn't seem ideal... > You are right, even if most of them are not used currently, that may change in the future so is safer to use it after all fields have been initialized. I'll double check all drivers to be sure that's the case. > > This is just adding the include to get the declaration of regulator_desc > as far as I can see, add a forward declaration of it instead. > Perfect, I didn't know what you would prefer. I'll change it in the next version. Best regards, Javier