Re: [PATCH nft 5/5] build: autotools conversion

[Giorgio <giorgio.nicole@arcor.de>]

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

On 11/06/2014 07:25 PM, Pablo Neira Ayuso wrote:

> diff --git a/Make_global.am b/Make_global.am
> new file mode 100644
> index 0000000..8ad0eb0
> --- /dev/null
> +++ b/Make_global.am
> @@ -0,0 +1,10 @@
> +AM_CPPFLAGS = -I$(top_srcdir)/include
> +AM_CPPFLAGS += -DDEFAULT_INCLUDE_PATH="\"${sysconfdir}\"" -D__USE_GNU
> +
> +AM_CFLAGS = -Wall	\
> +	    -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations	\
> +	    -Wdeclaration-after-statement -Wsign-compare -Winit-self		\
> +	    -Wformat-nonliteral -Wformat-security -Wmissing-format-attribute	\
> +	    -Wcast-align -Wundef -Wbad-function-cast # -Wshadow			\
> +	    -Waggregate-return -Wunused -Wwrite-strings				\
> +	    ${LIBMNL_CFLAGS} ${LIBNFTNL_CFLAGS}

why do you need this new file? The #include in the main Makefile.am is
useless because you do not build anything there; the only right place to
have these definitions is under src/Makefile.am.

giorgio



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 246 bytes --]