Re: [Qemu-devel] [PATCH] qapi: Complete BlkdebugEvent

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]

On 11/07/2014 04:51 PM, Max Reitz wrote:
> Several events were missing from the QAPI enum, add them.
> 
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  qapi/block-core.json | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Do we need any documentation on these? Or is this one of those types
where the only people using it are already expected to be familiar with
the C code?

> 
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 77a0cfb..8c3e45d 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -1422,7 +1422,9 @@
>              'refblock_alloc.write_blocks', 'refblock_alloc.write_table',
>              'refblock_alloc.switch_table', 'cluster_alloc',
>              'cluster_alloc_bytes', 'cluster_free', 'flush_to_os',
> -            'flush_to_disk' ] }
> +            'flush_to_disk', 'pwritev_rmw.head', 'pwritev_rmw.after_head',
> +            'pwritev_rmw.tail', 'pwritev_rmw.after_tail', 'pwritev',
> +            'pwritev_zero', 'pwritev_done', 'empty_image_prepare' ] }
>  
>  ##
>  # @BlkdebugInjectErrorOptions
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]