From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xmqfa-00084P-14 for qemu-devel@nongnu.org; Fri, 07 Nov 2014 16:02:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XmqfT-0001F6-Jn for qemu-devel@nongnu.org; Fri, 07 Nov 2014 16:02:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmqfT-0001Ez-CT for qemu-devel@nongnu.org; Fri, 07 Nov 2014 16:02:03 -0500 Message-ID: <545D3343.9000203@redhat.com> Date: Fri, 07 Nov 2014 22:01:55 +0100 From: Max Reitz MIME-Version: 1.0 References: <1415375495-14380-1-git-send-email-mreitz@redhat.com> <545D3247.9040905@redhat.com> In-Reply-To: <545D3247.9040905@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qapi: Complete BlkdebugEvent List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Lieven , Stefan Hajnoczi On 07.11.2014 21:57, Eric Blake wrote: > On 11/07/2014 04:51 PM, Max Reitz wrote: >> Several events were missing from the QAPI enum, add them. >> >> Reported-by: Kevin Wolf >> Signed-off-by: Max Reitz >> --- >> qapi/block-core.json | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) > Do we need any documentation on these? Or is this one of those types > where the only people using it are already expected to be familiar with > the C code? Well, you have to be familiar with the block driver as well. The documentation wouldn't be very useful, it'd be something like "refblock_alloc.write_blocks: Emitted when the new refblocks are written during qcow2 refblock allocation" or "empty_image_prepare: Emitted when qcow2 prepares to empty an image". So I'd leave the documentation out. Most users don't want to use this anyway, blkdebug is for debugging purposes only, so you need to know what the event does in the context of the block driver you're debugging anyway. Max >> diff --git a/qapi/block-core.json b/qapi/block-core.json >> index 77a0cfb..8c3e45d 100644 >> --- a/qapi/block-core.json >> +++ b/qapi/block-core.json >> @@ -1422,7 +1422,9 @@ >> 'refblock_alloc.write_blocks', 'refblock_alloc.write_table', >> 'refblock_alloc.switch_table', 'cluster_alloc', >> 'cluster_alloc_bytes', 'cluster_free', 'flush_to_os', >> - 'flush_to_disk' ] } >> + 'flush_to_disk', 'pwritev_rmw.head', 'pwritev_rmw.after_head', >> + 'pwritev_rmw.tail', 'pwritev_rmw.after_tail', 'pwritev', >> + 'pwritev_zero', 'pwritev_done', 'empty_image_prepare' ] } >> >> ## >> # @BlkdebugInjectErrorOptions >>