From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Rowand Subject: Re: [PATCH] tty: serial: msm_serial: Use DT aliases Date: Fri, 07 Nov 2014 13:35:45 -0800 Message-ID: <545D3B31.3030309@gmail.com> References: <1414024381-12204-1-git-send-email-sboyd@codeaurora.org> <545C694D.1030204@gmail.com> <545C69E7.6010909@gmail.com> <2747100.M77UGx4AmB@wuerfel> Reply-To: frowand.list@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f54.google.com ([209.85.220.54]:54992 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752682AbaKGVft (ORCPT ); Fri, 7 Nov 2014 16:35:49 -0500 In-Reply-To: <2747100.M77UGx4AmB@wuerfel> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Stephen Boyd , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-msm@vger.kernel.org On 11/7/2014 1:47 AM, Arnd Bergmann wrote: > On Thursday 06 November 2014 22:42:47 Frank Rowand wrote: >> This same change is also needed in: >> >> qcom-ipq8064.dtsi >> qcom-msm8960.dtsi >> qcom-apq8084.dtsi >> qcom-apq8064.dtsi >> qcom-msm8660.dtsi >> >> but I did not want to just blindly apply those changes without testing. >> > > Is there only one uart on each of these? > > If not, it would be better to put the aliases in the board specific file, > pointing to whichever ports are in use, in the order that makes sense > for that board. Good point, thanks for bringing it up. Your comment made me verify that the board dts files can override the aliases from the included .dtsi. So not a problem to have a default set of aliases in the .dtsi files. -Frank From mboxrd@z Thu Jan 1 00:00:00 1970 From: frowand.list@gmail.com (Frank Rowand) Date: Fri, 07 Nov 2014 13:35:45 -0800 Subject: [PATCH] tty: serial: msm_serial: Use DT aliases In-Reply-To: <2747100.M77UGx4AmB@wuerfel> References: <1414024381-12204-1-git-send-email-sboyd@codeaurora.org> <545C694D.1030204@gmail.com> <545C69E7.6010909@gmail.com> <2747100.M77UGx4AmB@wuerfel> Message-ID: <545D3B31.3030309@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/7/2014 1:47 AM, Arnd Bergmann wrote: > On Thursday 06 November 2014 22:42:47 Frank Rowand wrote: >> This same change is also needed in: >> >> qcom-ipq8064.dtsi >> qcom-msm8960.dtsi >> qcom-apq8084.dtsi >> qcom-apq8064.dtsi >> qcom-msm8660.dtsi >> >> but I did not want to just blindly apply those changes without testing. >> > > Is there only one uart on each of these? > > If not, it would be better to put the aliases in the board specific file, > pointing to whichever ports are in use, in the order that makes sense > for that board. Good point, thanks for bringing it up. Your comment made me verify that the board dts files can override the aliases from the included .dtsi. So not a problem to have a default set of aliases in the .dtsi files. -Frank