All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel@daenzer.net>
To: Rob Clark <robdclark@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/irq: BUG_ON() -> WARN_ON()
Date: Mon, 10 Nov 2014 12:57:33 +0900	[thread overview]
Message-ID: <546037AD.7090709@daenzer.net> (raw)
In-Reply-To: <1415459779-30961-1-git-send-email-robdclark@gmail.com>

On 09.11.2014 00:16, Rob Clark wrote:
> Let's make things a bit easier to debug when things go bad (potentially
> under console_lock).
>
> Signed-off-by: Rob Clark <robdclark@gmail.com>
> ---
>   drivers/gpu/drm/drm_irq.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
> index 5ef03c2..c4edea9 100644
> --- a/drivers/gpu/drm/drm_irq.c
> +++ b/drivers/gpu/drm/drm_irq.c
> @@ -1029,7 +1029,8 @@ void drm_vblank_put(struct drm_device *dev, int crtc)
>   {
>   	struct drm_vblank_crtc *vblank = &dev->vblank[crtc];
>
> -	BUG_ON(atomic_read(&vblank->refcount) == 0);
> +	if (WARN_ON(atomic_read(&vblank->refcount) == 0))
> +		return;
>
>   	if (WARN_ON(crtc >= dev->num_crtcs))
>   		return;
>

Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2014-11-10  3:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-08 15:16 [PATCH] drm/irq: BUG_ON() -> WARN_ON() Rob Clark
2014-11-10  3:57 ` Michel Dänzer [this message]
2014-11-10 11:01 ` Jani Nikula
2014-11-10 11:33   ` Maarten Lankhorst
2014-11-10 11:33     ` Maarten Lankhorst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546037AD.7090709@daenzer.net \
    --to=michel@daenzer.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=robdclark@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.