From: Beomho Seo <beomho.seo@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 5/5] Documentation: Add documentation for rt5033 multifunction device
Date: Mon, 10 Nov 2014 14:40:57 +0900 [thread overview]
Message-ID: <54604FE9.8070902@samsung.com> (raw)
In-Reply-To: <20141107103440.GD8509@sirena.org.uk>
Thank you for your advice.
I'll fix them and send v2 patch soon.
On 11/07/2014 07:34 PM, Mark Brown wrote:
> On Fri, Nov 07, 2014 at 11:52:07AM +0900, Beomho Seo wrote:
>
>> +Required properties:
>> +- compatible = Must be "richtek,rt5033-regulator"
>> +
>> + regulators {
>> + compatible = "richtek,rt5033-regulator";
>
> There should be no need for this extra compatible, it's not adding
> anything we didn't know from the fact that it's part of the MFD.
>
>> + regulator-name {
>> + regulator-name = LDO/BUCK
>> + standard regulator constraints...
>> + };
>
> Better to just say something like "regulator subnodes called X, Y and Z"
> described using the standard regulator binding in...
>
Best regards,
Beomho Seo
prev parent reply other threads:[~2014-11-10 5:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 2:52 [PATCH 0/5] mfd: rt5033: Add Richtek RT5033 drivers Beomho Seo
2014-11-07 2:52 ` [PATCH 1/5] mfd: rt5033: Add Richtek RT5033 driver core Beomho Seo
2014-11-07 2:52 ` [PATCH 2/5] regulator: rt5033: Add RT5033 Regulator device driver Beomho Seo
[not found] ` <1415328727-16245-3-git-send-email-beomho.seo-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-07 10:27 ` Mark Brown
2014-11-07 10:27 ` Mark Brown
2014-11-07 2:52 ` [PATCH 3/5] power: rt5033_battery: Add RT5033 Fuel gauge " Beomho Seo
2014-11-07 2:52 ` [PATCH 4/5] power: rt5033_charger: Add RT5033 charger " Beomho Seo
2014-11-07 2:52 ` [PATCH 5/5] Documentation: Add documentation for rt5033 multifunction device Beomho Seo
2014-11-07 10:34 ` Mark Brown
2014-11-10 5:40 ` Beomho Seo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54604FE9.8070902@samsung.com \
--to=beomho.seo@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.