All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@ozlabs.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: openipmi-developer@lists.sourceforge.net,
	linuxppc-dev@lists.ozlabs.org, minyard@acm.org
Subject: Re: [PATCH 0/2] Add IPMI support for powernv powerpc machines
Date: Mon, 10 Nov 2014 14:41:04 +0800	[thread overview]
Message-ID: <54605E00.1050704@ozlabs.org> (raw)
In-Reply-To: <1415598090.5769.15.camel@kernel.crashing.org>

Hi Ben,

> Our OPAL interface can only do one at a time ? Because our underlying
> FW driver already has a queue ..

The Linux driver needs to match responses to their requests, so the
driver needs to keep a reference to the requests that we've sent. The
current implementation is very simple: we just keep one pointer, and
require that there's only one outstanding request.

To have multiple outstanding requests, our options here are that we either:

1) duplicate the si_intf's queuing code in the powernv driver; or

2) move the queuing code from the si_intf component to the generic
   IPMI msghander, and use that (so all drivers can assume a single
   outstanding request)

Corey has suggested the latter, which will only require a minimal change
to the powerpv IPMI driver.

Cheers,


Jeremy

  parent reply	other threads:[~2014-11-10  6:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06  3:38 [PATCH 0/2] Add IPMI support for powernv powerpc machines Jeremy Kerr
2014-11-06  3:38 ` [PATCH 2/2] drivers/char/ipmi: Add powernv IPMI driver Jeremy Kerr
2014-11-06  3:38 ` [PATCH 1/2] powerpc/powernv: Add OPAL IPMI interface Jeremy Kerr
2014-11-06 14:15 ` [PATCH 0/2] Add IPMI support for powernv powerpc machines Corey Minyard
2014-11-10  3:26   ` Jeremy Kerr
2014-11-10  5:41     ` Benjamin Herrenschmidt
2014-11-10  6:01       ` Alistair Popple
2014-11-10  6:57         ` Benjamin Herrenschmidt
2014-11-10  6:41       ` Jeremy Kerr [this message]
2014-11-11 21:07     ` Corey Minyard
2014-11-12  6:10   ` Michael Ellerman
2014-11-12  7:37     ` Jeremy Kerr
2014-11-12  7:41     ` [PATCH v2] drivers/char/ipmi: Add powernv IPMI driver Jeremy Kerr
2014-11-14  1:42       ` Corey Minyard
2014-11-14  2:00         ` Jeremy Kerr
2014-11-14  2:04         ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54605E00.1050704@ozlabs.org \
    --to=jk@ozlabs.org \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=minyard@acm.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.