From: Lars-Peter Clausen <lars@metafoo.de>
To: NeilBrown <neilb@suse.de>, Mark Brown <broonie@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
GTA04 owners <gta04-owner@goldelico.com>,
alsa-devel@alsa-project.org, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [alsa-devel] [PATCH 1/3] ASoC: twl4030: don't report EBUSY if no change requested.
Date: Mon, 10 Nov 2014 08:07:50 +0100 [thread overview]
Message-ID: <54606446.7030907@metafoo.de> (raw)
In-Reply-To: <20141110114518.715dcd4e@notabene.brown>
On 11/10/2014 01:45 AM, NeilBrown wrote:
> diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
> index b6b0cb399599..613b61cee081 100644
> --- a/sound/soc/codecs/twl4030.c
> +++ b/sound/soc/codecs/twl4030.c
> @@ -957,6 +957,16 @@ static int snd_soc_put_twl4030_opmode_enum_double(struct snd_kcontrol *kcontrol,
> {
> struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
> struct twl4030_priv *twl4030 = snd_soc_codec_get_drvdata(codec);
> + struct snd_ctl_elem_value currentval;
>
snd_ctl_elem_value is a bit to big to be put onto the kernel stack. Just
using twl4030_read() should be fine.
next prev parent reply other threads:[~2014-11-10 7:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-08 0:38 [PATCH 0/3] ASoC: twl4030: support routine to external VOICE source NeilBrown
2014-11-08 0:38 ` NeilBrown
2014-11-08 0:38 ` [PATCH 2/3] ASoC: twl4030: allow voice port to be connected externally NeilBrown
2014-11-08 9:26 ` Mark Brown
2014-11-08 9:26 ` Mark Brown
2014-11-09 23:25 ` NeilBrown
2014-11-09 23:25 ` NeilBrown
2014-11-10 6:46 ` [Gta04-owner] " Dr. H. Nikolaus Schaller
[not found] ` <20141110102551.2678d342-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2014-11-10 12:11 ` Mark Brown
2014-11-10 12:11 ` Mark Brown
2014-11-08 0:38 ` [PATCH 3/3] ASoC: twl4030: enable routing audio to 'voice' interface NeilBrown
2014-11-08 9:27 ` Mark Brown
2014-11-09 23:54 ` NeilBrown
2014-11-10 10:48 ` Mark Brown
2014-11-08 0:38 ` [PATCH 1/3] ASoC: twl4030: don't report EBUSY if no change requested NeilBrown
[not found] ` <20141108003803.6561.42934.stgit-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2014-11-08 9:22 ` Mark Brown
2014-11-08 9:22 ` Mark Brown
[not found] ` <20141108092242.GB2722-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-11-10 0:45 ` NeilBrown
2014-11-10 0:45 ` NeilBrown
2014-11-10 7:07 ` Lars-Peter Clausen [this message]
[not found] ` <54606446.7030907-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-11-10 21:45 ` [alsa-devel] " NeilBrown
2014-11-10 21:45 ` NeilBrown
[not found] ` <20141111084537.1b4e726c-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2014-11-10 21:49 ` Lars-Peter Clausen
2014-11-10 21:49 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54606446.7030907@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gta04-owner@goldelico.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=neilb@suse.de \
--cc=pawel.moll@arm.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.