From: Damien Zammit <damien.zammit@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Clemens Ladisch <clemens@ladisch.de>
Subject: Re: [PATCH 2/2] snd-usb-audio: Add duplex mode for Digidesign Mbox 1 and enable mixer
Date: Mon, 10 Nov 2014 18:34:25 +1100 [thread overview]
Message-ID: <54606A81.6080009@gmail.com> (raw)
In-Reply-To: <s5hbnof3632.wl-tiwai@suse.de>
On 10/11/14 17:47, Takashi Iwai wrote:
> My bad, take the additional fix patch below.
>
> Takashi
>
> -- 8< --
> From: Takashi Iwai <tiwai@suse.de>
> Subject: [PATCH] ALSA: usb-audio: Fix Oops by composite quirk enhancement
>
> The quirk argument itself was used as iterator, so it cannot be taken
> back to the original value, obviously.
>
> Fixes: d4b8fc66f770 ('ALSA: usb-audio: Allow multiple entries for the same iface in composite quirk')
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
> sound/usb/quirks.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
I confirm that this fixes the kernel oops, and the logic works. See
next patch series for working patch!
Damien
prev parent reply other threads:[~2014-11-10 7:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 0:06 [PATCH 0/2] Digidesign Mbox 1 duplex mode and mixer Damien Zammit
2014-11-04 0:06 ` [PATCH 1/2] snd-usb-audio: Add mixer control for Digidesign Mbox 1 clock source Damien Zammit
2014-11-06 14:12 ` Takashi Iwai
2014-11-08 13:30 ` Damien Zammit
2014-11-09 9:02 ` Takashi Iwai
2014-11-04 0:06 ` [PATCH 2/2] snd-usb-audio: Add duplex mode for Digidesign Mbox 1 and enable mixer Damien Zammit
2014-11-06 14:15 ` Takashi Iwai
2014-11-08 13:35 ` Damien Zammit
2014-11-09 9:18 ` Takashi Iwai
2014-11-09 14:04 ` Clemens Ladisch
2014-11-09 17:27 ` Takashi Iwai
2014-11-09 23:45 ` Damien Zammit
2014-11-10 1:33 ` Damien Zammit
2014-11-10 6:47 ` Takashi Iwai
2014-11-10 7:34 ` Damien Zammit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54606A81.6080009@gmail.com \
--to=damien.zammit@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.